From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 647AC81E5E for ; Thu, 10 Nov 2016 21:18:43 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 10 Nov 2016 21:18:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,620,1473145200"; d="scan'208";a="1067039982" Received: from jiaxinwu-mobl2.ccr.corp.intel.com ([10.239.196.64]) by fmsmga001.fm.intel.com with ESMTP; 10 Nov 2016 21:18:45 -0800 From: Jiaxin Wu To: edk2-devel@lists.01.org Cc: Santhapur Naveen , Laszlo Ersek , Ye Ting , Fu Siyuan Date: Fri, 11 Nov 2016 13:18:40 +0800 Message-Id: <1478841521-232036-2-git-send-email-jiaxin.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 In-Reply-To: <1478841521-232036-1-git-send-email-jiaxin.wu@intel.com> References: <1478841521-232036-1-git-send-email-jiaxin.wu@intel.com> Subject: [PATCH v2 1/2] MdeModulePkg/Ip4Dxe: Add wrong/invalid subnet check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 05:18:43 -0000 v2: * Separate out the return status fix. * Replace IP4_MASK_MAX with IP4_MASK_MAX. * Remove the ON_EXIT label. This patch is used to add the wrong/invalid subnet check. Cc: Santhapur Naveen Cc: Laszlo Ersek Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 10 +++++++--- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c | 8 +++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c index a931bb3..5b01b35 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Config2Impl.c @@ -1253,10 +1253,17 @@ Ip4Config2SetMaunualAddress ( return EFI_WRITE_PROTECTED; } NewAddress = *((EFI_IP4_CONFIG2_MANUAL_ADDRESS *) Data); + StationAddress = EFI_NTOHL (NewAddress.Address); + SubnetMask = EFI_NTOHL (NewAddress.SubnetMask); + + if (NetGetMaskLength (SubnetMask) == IP4_MASK_NUM) { + return EFI_INVALID_PARAMETER; + } + // // Store the new data, and init the DataItem status to EFI_NOT_READY because // we may have an asynchronous configuration process. // Ptr = AllocateCopyPool (DataSize, Data); @@ -1271,13 +1278,10 @@ Ip4Config2SetMaunualAddress ( DataItem->Data.Ptr = Ptr; DataItem->DataSize = DataSize; DataItem->Status = EFI_NOT_READY; - StationAddress = EFI_NTOHL (NewAddress.Address); - SubnetMask = EFI_NTOHL (NewAddress.SubnetMask); - IpSb->Reconfig = TRUE; Status = Ip4Config2SetDefaultAddr (IpSb, StationAddress, SubnetMask); if (EFI_ERROR (Status)) { goto ON_EXIT; } diff --git a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c index 9cd5dd5..b0cc6a3 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c @@ -562,10 +562,15 @@ Ip4SetAddress ( EFI_STATUS Status; INTN Len; NET_CHECK_SIGNATURE (Interface, IP4_INTERFACE_SIGNATURE); + Len = NetGetMaskLength (SubnetMask); + if (Len == IP4_MASK_NUM) { + return EFI_INVALID_PARAMETER; + } + // // Set the ip/netmask, then compute the subnet broadcast // and network broadcast for easy access. When computing // nework broadcast, the subnet mask is most like longer // than the default netmask (not subneted) as defined in @@ -573,13 +578,10 @@ Ip4SetAddress ( // networks, use the subnet's mask instead. // Interface->Ip = IpAddr; Interface->SubnetMask = SubnetMask; Interface->SubnetBrdcast = (IpAddr | ~SubnetMask); - - Len = NetGetMaskLength (SubnetMask); - ASSERT (Len <= IP4_MASK_MAX); Interface->NetBrdcast = (IpAddr | ~SubnetMask); // // Do clean up for Arp child // -- 1.9.5.msysgit.1