From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1754F81C9A for ; Sun, 13 Nov 2016 18:24:35 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 13 Nov 2016 18:24:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="30861120" Received: from shwde7172.ccr.corp.intel.com ([10.239.9.23]) by fmsmga006.fm.intel.com with ESMTP; 13 Nov 2016 18:24:38 -0800 From: Liming Gao To: edk2-devel@lists.01.org Cc: Michael Kinney Date: Mon, 14 Nov 2016 10:24:36 +0800 Message-Id: <1479090276-29344-1-git-send-email-liming.gao@intel.com> X-Mailer: git-send-email 2.8.0.windows.1 In-Reply-To: <1478835172-32372-1-git-send-email-liming.gao@intel.com> References: <1478835172-32372-1-git-send-email-liming.gao@intel.com> Subject: [PATCH v2] MdePkg Base.h: Update field name in VERIFY_UINTXX_ENUM_SIZE to follow style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 02:24:35 -0000 In V2, add comments on why uses __ prefix in enum type name. For field name in structure, its first character should be upper case. Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h index 5e24b5d..ce6cb07 100644 --- a/MdePkg/Include/Base.h +++ b/MdePkg/Include/Base.h @@ -63,16 +63,21 @@ VERIFY_SIZE_OF (UINT64, 8); VERIFY_SIZE_OF (CHAR8, 1); VERIFY_SIZE_OF (CHAR16, 2); +// +// Those three enum types are only used to verify compiler config is right. +// They are not used by any source code. So, __ prefix is added for them to +// avoid their name conflict with other types. +// typedef enum { - __VerifyUint8EnumValue = 0xff + VerifyUint8EnumValue = 0xff } __VERIFY_UINT8_ENUM_SIZE; typedef enum { - __VerifyUint16EnumValue = 0xffff + VerifyUint16EnumValue = 0xffff } __VERIFY_UINT16_ENUM_SIZE; typedef enum { - __VerifyUint32EnumValue = 0xffffffff + VerifyUint32EnumValue = 0xffffffff } __VERIFY_UINT32_ENUM_SIZE; VERIFY_SIZE_OF (__VERIFY_UINT8_ENUM_SIZE, 4); -- 2.8.0.windows.1