From: Jeremy Linton <jeremy.linton@arm.com>
To: edk2-devel@lists.01.org
Cc: linaro-uefi@lists.linaro.org, ryan.harkin@linaro.org,
leif.lindholm@linaro.org, steve.capper@arm.com,
evan.lloyd@arm.com, daniil.egranov@arm.com,
Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH 7/7] EmbeddedPkg: SiI3132: Correct the IoAlign
Date: Mon, 14 Nov 2016 15:09:48 -0600 [thread overview]
Message-ID: <1479157789-14674-8-git-send-email-jeremy.linton@arm.com> (raw)
In-Reply-To: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com>
With the update to the DMA lib, and the FIS submission
cleanups the SiI driver now works fine with alignments
less than a full page. Large alignment requirements
cause problems with grub. Decrease it to a sane value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
index 52b79fd..737e398 100644
--- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
+++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c
@@ -103,7 +103,7 @@ SataSiI3132Constructor (
Instance->PciIo = PciIo;
Instance->AtaPassThruMode.Attributes = EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_ATA_PASS_THRU_ATTRIBUTES_LOGICAL;
- Instance->AtaPassThruMode.IoAlign = 0x1000;
+ Instance->AtaPassThruMode.IoAlign = 0x4;
// Initialize SiI3132 ports
SataSiI3132PortConstructor (Instance, 0);
@@ -120,7 +120,7 @@ SataSiI3132Constructor (
Instance->AtaPassThruProtocol.ResetDevice = SiI3132ResetDevice;
Instance->ExtScsiPassThruMode.Attributes = EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL;
- Instance->ExtScsiPassThruMode.IoAlign = 0x1000;
+ Instance->ExtScsiPassThruMode.IoAlign = 0x4;
// Set SCSI Pass Thru Protocol
Instance->ExtScsiPassThru.Mode = &Instance->ExtScsiPassThruMode;
--
2.5.5
next prev parent reply other threads:[~2016-11-14 21:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 21:09 [PATCH 0/8] ATAPI support on SiI SATA adapter Jeremy Linton
2016-11-14 21:09 ` [PATCH 1/7] MdePkg IndustryStandard/Scsi.h: Add sense code macro Jeremy Linton
2016-11-15 7:38 ` Ard Biesheuvel
2016-11-15 10:51 ` Gao, Liming
2016-11-14 21:09 ` [PATCH 2/7] EmbeddedPkg: SiI3132: Add ScsiProtocol callbacks Jeremy Linton
2016-11-15 16:04 ` Ard Biesheuvel
2016-11-14 21:09 ` [PATCH 3/7] EmbeddedPkg: SiI3132: Add SCSI protocol support to header Jeremy Linton
2016-11-14 21:24 ` Jeremy Linton
2016-11-15 17:02 ` Ard Biesheuvel
2016-11-16 15:44 ` Ryan Harkin
2016-11-14 21:09 ` [PATCH 4/7] EmbeddedPkg: SiI3132: Break out FIS command submission Jeremy Linton
2016-11-15 17:10 ` Ard Biesheuvel
2016-11-14 21:09 ` [PATCH 5/7] EmbeddedPkg: SiI3132: Cleanup device node creation Jeremy Linton
2016-11-14 21:09 ` [PATCH 6/7] EmbeddedPkg: SiI3132: Enable SCSI pass-through protocol Jeremy Linton
2016-11-14 21:09 ` Jeremy Linton [this message]
2016-11-14 21:09 ` [PATCH] Platforms/ARM/Juno: Add " Jeremy Linton
2016-11-15 7:43 ` [PATCH 0/8] ATAPI support on SiI SATA adapter Ard Biesheuvel
2016-11-15 14:54 ` Jeremy Linton
2016-11-15 14:57 ` Ard Biesheuvel
2016-11-15 15:05 ` Jeremy Linton
2016-11-15 15:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479157789-14674-8-git-send-email-jeremy.linton@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox