From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by ml01.01.org (Postfix) with ESMTP id 3425281E1F for ; Mon, 14 Nov 2016 13:10:20 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFAD8AD7; Mon, 14 Nov 2016 13:10:24 -0800 (PST) Received: from u200856.usa.arm.com (u201426.usa.arm.com [10.118.28.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6A0FC3F218; Mon, 14 Nov 2016 13:10:24 -0800 (PST) From: Jeremy Linton To: edk2-devel@lists.01.org Cc: linaro-uefi@lists.linaro.org, ryan.harkin@linaro.org, leif.lindholm@linaro.org, steve.capper@arm.com, evan.lloyd@arm.com, daniil.egranov@arm.com, Jeremy Linton Date: Mon, 14 Nov 2016 15:09:48 -0600 Message-Id: <1479157789-14674-8-git-send-email-jeremy.linton@arm.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> References: <1479157789-14674-1-git-send-email-jeremy.linton@arm.com> Subject: [PATCH 7/7] EmbeddedPkg: SiI3132: Correct the IoAlign X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 21:10:20 -0000 With the update to the DMA lib, and the FIS submission cleanups the SiI driver now works fine with alignments less than a full page. Large alignment requirements cause problems with grub. Decrease it to a sane value. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeremy Linton --- EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c index 52b79fd..737e398 100644 --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.c @@ -103,7 +103,7 @@ SataSiI3132Constructor ( Instance->PciIo = PciIo; Instance->AtaPassThruMode.Attributes = EFI_ATA_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_ATA_PASS_THRU_ATTRIBUTES_LOGICAL; - Instance->AtaPassThruMode.IoAlign = 0x1000; + Instance->AtaPassThruMode.IoAlign = 0x4; // Initialize SiI3132 ports SataSiI3132PortConstructor (Instance, 0); @@ -120,7 +120,7 @@ SataSiI3132Constructor ( Instance->AtaPassThruProtocol.ResetDevice = SiI3132ResetDevice; Instance->ExtScsiPassThruMode.Attributes = EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_PHYSICAL | EFI_EXT_SCSI_PASS_THRU_ATTRIBUTES_LOGICAL; - Instance->ExtScsiPassThruMode.IoAlign = 0x1000; + Instance->ExtScsiPassThruMode.IoAlign = 0x4; // Set SCSI Pass Thru Protocol Instance->ExtScsiPassThru.Mode = &Instance->ExtScsiPassThruMode; -- 2.5.5