[Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization.

[Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization.

[Eric Dong]

The memory will be set to background color after success allocate
the data, so not need to call AllocateZeroPool.

Related bugz: https://bugzilla.tianocore.org/show_bug.cgi?id=223

Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
index 7855c7e..9bef064 100644
--- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
+++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
@@ -2056,7 +2056,7 @@ HiiStringToImage (
     if ((Flags & EFI_HII_DIRECT_TO_SCREEN) == EFI_HII_DIRECT_TO_SCREEN) {
       BltBuffer = NULL;
       if (RowInfo[RowIndex].LineWidth != 0) {
-        BltBuffer = AllocateZeroPool (RowInfo[RowIndex].LineWidth * RowInfo[RowIndex].LineHeight * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
+        BltBuffer = AllocatePool (RowInfo[RowIndex].LineWidth * RowInfo[RowIndex].LineHeight * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
         if (BltBuffer == NULL) {
           Status = EFI_OUT_OF_RESOURCES;
           goto Exit;
-- 
2.6.4.windows.1

Re: [Patch] MdeModulePkg HiiDatabase: Remove extra memory initialization.

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Dong, Eric
> Sent: Tuesday, November 15, 2016 10:29 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [Patch] MdeModulePkg HiiDatabase: Remove extra memory
> initialization.
> 
> The memory will be set to background color after success allocate
> the data, so not need to call AllocateZeroPool.
> 
> Related bugz: https://bugzilla.tianocore.org/show_bug.cgi?id=223
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/Font.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> index 7855c7e..9bef064 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/Font.c
> @@ -2056,7 +2056,7 @@ HiiStringToImage (
>      if ((Flags & EFI_HII_DIRECT_TO_SCREEN) == EFI_HII_DIRECT_TO_SCREEN) {
>        BltBuffer = NULL;
>        if (RowInfo[RowIndex].LineWidth != 0) {
> -        BltBuffer = AllocateZeroPool (RowInfo[RowIndex].LineWidth *
> RowInfo[RowIndex].LineHeight * sizeof
> (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
> +        BltBuffer = AllocatePool (RowInfo[RowIndex].LineWidth *
> RowInfo[RowIndex].LineHeight * sizeof
> (EFI_GRAPHICS_OUTPUT_BLT_PIXEL));
>          if (BltBuffer == NULL) {
>            Status = EFI_OUT_OF_RESOURCES;
>            goto Exit;
> --
> 2.6.4.windows.1