* [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb @ 2016-11-15 6:29 Liming Gao 2016-11-15 7:03 ` Zhu, Yonghong ` (2 more replies) 0 siblings, 3 replies; 7+ messages in thread From: Liming Gao @ 2016-11-15 6:29 UTC (permalink / raw) To: edk2-devel Cc: Yonghong Zhu <yonghong.zhu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao <liming.gao@intel.com> --- BaseTools/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index 5ca024c..d737258 100644 --- a/BaseTools/.gitignore +++ b/BaseTools/.gitignore @@ -1,5 +1,7 @@ *.d *.o +*.obj +*.pdb *.pyc Source/C/VfrCompile/EfiVfrParser.cpp Source/C/VfrCompile/EfiVfrParser.h -- 2.8.0.windows.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-15 6:29 [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming Gao @ 2016-11-15 7:03 ` Zhu, Yonghong 2016-11-15 7:16 ` Kinney, Michael D 2016-11-15 10:39 ` [PATCH v2] " Liming Gao 2 siblings, 0 replies; 7+ messages in thread From: Zhu, Yonghong @ 2016-11-15 7:03 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com> Best Regards, Zhu Yonghong -----Original Message----- From: Gao, Liming Sent: Tuesday, November 15, 2016 2:30 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong <yonghong.zhu@intel.com> Subject: [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Cc: Yonghong Zhu <yonghong.zhu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao <liming.gao@intel.com> --- BaseTools/.gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index 5ca024c..d737258 100644 --- a/BaseTools/.gitignore +++ b/BaseTools/.gitignore @@ -1,5 +1,7 @@ *.d *.o +*.obj +*.pdb *.pyc Source/C/VfrCompile/EfiVfrParser.cpp Source/C/VfrCompile/EfiVfrParser.h -- 2.8.0.windows.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-15 6:29 [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming Gao 2016-11-15 7:03 ` Zhu, Yonghong @ 2016-11-15 7:16 ` Kinney, Michael D 2016-11-15 10:39 ` [PATCH v2] " Liming Gao 2 siblings, 0 replies; 7+ messages in thread From: Kinney, Michael D @ 2016-11-15 7:16 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org, Kinney, Michael D Liming, When I do a build of BaseTools, I see some additional files in Pccts with different extensions. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > Sent: Monday, November 14, 2016 10:30 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj > and *.pdb > > Cc: Yonghong Zhu <yonghong.zhu@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <liming.gao@intel.com> > --- > BaseTools/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore > index 5ca024c..d737258 100644 > --- a/BaseTools/.gitignore > +++ b/BaseTools/.gitignore > @@ -1,5 +1,7 @@ > *.d > *.o > +*.obj > +*.pdb > *.pyc > Source/C/VfrCompile/EfiVfrParser.cpp > Source/C/VfrCompile/EfiVfrParser.h > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-15 6:29 [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming Gao 2016-11-15 7:03 ` Zhu, Yonghong 2016-11-15 7:16 ` Kinney, Michael D @ 2016-11-15 10:39 ` Liming Gao 2016-11-15 16:25 ` Kinney, Michael D 2 siblings, 1 reply; 7+ messages in thread From: Liming Gao @ 2016-11-15 10:39 UTC (permalink / raw) To: edk2-devel In V2, ignore .exe and .ilk files Cc: Yonghong Zhu <yonghong.zhu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao <liming.gao@intel.com> --- BaseTools/.gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore index 5ca024c..a45689b 100644 --- a/BaseTools/.gitignore +++ b/BaseTools/.gitignore @@ -1,5 +1,9 @@ *.d *.o +*.obj +*.pdb +*.ilk +*.exe *.pyc Source/C/VfrCompile/EfiVfrParser.cpp Source/C/VfrCompile/EfiVfrParser.h -- 2.8.0.windows.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-15 10:39 ` [PATCH v2] " Liming Gao @ 2016-11-15 16:25 ` Kinney, Michael D 2016-11-16 1:27 ` Gao, Liming 0 siblings, 1 reply; 7+ messages in thread From: Kinney, Michael D @ 2016-11-15 16:25 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org, Kinney, Michael D Liming, The current patch would ignore .exe in BaseTools/Bin Since you had to add .exe, should this be done in .gitignore in BaseTools/Source instead? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > Sent: Tuesday, November 15, 2016 2:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files > *.obj and *.pdb > > In V2, ignore .exe and .ilk files > > Cc: Yonghong Zhu <yonghong.zhu@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao <liming.gao@intel.com> > --- > BaseTools/.gitignore | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore > index 5ca024c..a45689b 100644 > --- a/BaseTools/.gitignore > +++ b/BaseTools/.gitignore > @@ -1,5 +1,9 @@ > *.d > *.o > +*.obj > +*.pdb > +*.ilk > +*.exe > *.pyc > Source/C/VfrCompile/EfiVfrParser.cpp > Source/C/VfrCompile/EfiVfrParser.h > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-15 16:25 ` Kinney, Michael D @ 2016-11-16 1:27 ` Gao, Liming 2016-11-16 16:36 ` Kinney, Michael D 0 siblings, 1 reply; 7+ messages in thread From: Gao, Liming @ 2016-11-16 1:27 UTC (permalink / raw) To: Kinney, Michael D, edk2-devel@lists.01.org Mike: We don't need to add C tools .exe in edk2 git repo. All C tools .exe are in another git repo edk2-BaseTools-win32. And, Bin/Win32 directory is already in .gitignore. All exe files in Bin directory have been ignored. Thanks Liming From: Kinney, Michael D Sent: Wednesday, November 16, 2016 12:25 AM To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming, The current patch would ignore .exe in BaseTools/Bin Since you had to add .exe, should this be done in .gitignore in BaseTools/Source instead? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > Sent: Tuesday, November 15, 2016 2:40 AM > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files > *.obj and *.pdb > > In V2, ignore .exe and .ilk files > > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > BaseTools/.gitignore | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore > index 5ca024c..a45689b 100644 > --- a/BaseTools/.gitignore > +++ b/BaseTools/.gitignore > @@ -1,5 +1,9 @@ > *.d > *.o > +*.obj > +*.pdb > +*.ilk > +*.exe > *.pyc > Source/C/VfrCompile/EfiVfrParser.cpp > Source/C/VfrCompile/EfiVfrParser.h > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb 2016-11-16 1:27 ` Gao, Liming @ 2016-11-16 16:36 ` Kinney, Michael D 0 siblings, 0 replies; 7+ messages in thread From: Kinney, Michael D @ 2016-11-16 16:36 UTC (permalink / raw) To: Gao, Liming, edk2-devel@lists.01.org, Kinney, Michael D Liming, I agree. The current patch is good. Reviewed-by: Michael Kinney <michael.d.kinney@intel.com> Mike From: Gao, Liming Sent: Tuesday, November 15, 2016 5:27 PM To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Mike: We don't need to add C tools .exe in edk2 git repo. All C tools .exe are in another git repo edk2-BaseTools-win32. And, Bin/Win32 directory is already in .gitignore. All exe files in Bin directory have been ignored. Thanks Liming From: Kinney, Michael D Sent: Wednesday, November 16, 2016 12:25 AM To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com> Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming, The current patch would ignore .exe in BaseTools/Bin Since you had to add .exe, should this be done in .gitignore in BaseTools/Source instead? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao > Sent: Tuesday, November 15, 2016 2:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files > *.obj and *.pdb > > In V2, ignore .exe and .ilk files > > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > BaseTools/.gitignore | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore > index 5ca024c..a45689b 100644 > --- a/BaseTools/.gitignore > +++ b/BaseTools/.gitignore > @@ -1,5 +1,9 @@ > *.d > *.o > +*.obj > +*.pdb > +*.ilk > +*.exe > *.pyc > Source/C/VfrCompile/EfiVfrParser.cpp > Source/C/VfrCompile/EfiVfrParser.h > -- > 2.8.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-16 16:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-15 6:29 [Patch] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Liming Gao 2016-11-15 7:03 ` Zhu, Yonghong 2016-11-15 7:16 ` Kinney, Michael D 2016-11-15 10:39 ` [PATCH v2] " Liming Gao 2016-11-15 16:25 ` Kinney, Michael D 2016-11-16 1:27 ` Gao, Liming 2016-11-16 16:36 ` Kinney, Michael D
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox