public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH] SignedCapsulePkg IniParsingLib: ASSERT to ensure 'Value' is not NULL
Date: Wed, 16 Nov 2016 16:26:01 +0800	[thread overview]
Message-ID: <1479284761-15060-1-git-send-email-hao.a.wu@intel.com> (raw)

Function GetStringFromDataFile() ensures its fourth (output) parameter
will not be NULL when the return status is EFI_SUCCESS.

This commit adds ASSERT as warnings for the case that will not happen.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
index a8773c1..5c975f7 100644
--- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
+++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
@@ -1257,6 +1257,7 @@ GetGuidFromDataFile (
   if (EFI_ERROR(Status)) {
     return EFI_NOT_FOUND;
   }
+  ASSERT (Value != NULL);
   if (!IsValidGuid(Value, AsciiStrLen(Value))) {
     return EFI_NOT_FOUND;
   }
@@ -1303,6 +1304,7 @@ GetDecimalUintnFromDataFile (
   if (EFI_ERROR(Status)) {
     return EFI_NOT_FOUND;
   }
+  ASSERT (Value != NULL);
   if (!IsValidDecimalString(Value, AsciiStrLen(Value))) {
     return EFI_NOT_FOUND;
   }
@@ -1346,6 +1348,7 @@ GetHexUintnFromDataFile (
   if (EFI_ERROR(Status)) {
     return EFI_NOT_FOUND;
   }
+  ASSERT (Value != NULL);
   if (!IsValidHexString(Value, AsciiStrLen(Value))) {
     return EFI_NOT_FOUND;
   }
@@ -1389,6 +1392,7 @@ GetHexUint64FromDataFile (
   if (EFI_ERROR(Status)) {
     return EFI_NOT_FOUND;
   }
+  ASSERT (Value != NULL);
   if (!IsValidHexString(Value, AsciiStrLen(Value))) {
     return EFI_NOT_FOUND;
   }
-- 
1.9.5.msysgit.0



             reply	other threads:[~2016-11-16  8:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16  8:26 Hao Wu [this message]
2016-11-16  8:37 ` [PATCH] SignedCapsulePkg IniParsingLib: ASSERT to ensure 'Value' is not NULL Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479284761-15060-1-git-send-email-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox