From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
Laszlo Ersek <lersek@redhat.com>, Andrew Fish <afish@apple.com>,
Jeff Fan <jeff.fan@intel.com>
Subject: [Patch v2 3/3] MdePkg/BaseSynchronizationLib: Fix function names in function headers
Date: Thu, 17 Nov 2016 11:34:42 -0800 [thread overview]
Message-ID: <1479411282-10996-4-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1479411282-10996-1-git-send-email-michael.d.kinney@intel.com>
Some of the function names in function header comment blocks in
assembly files do not match the symbol name in the assembly sources.
Update function header comment blocks to match symbol name.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
.../Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.asm | 2 +-
.../BaseSynchronizationLib/X64/InterlockedCompareExchange16.nasm | 2 +-
.../Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.asm | 2 +-
.../BaseSynchronizationLib/X64/InterlockedCompareExchange32.nasm | 2 +-
.../Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.asm | 2 +-
.../BaseSynchronizationLib/X64/InterlockedCompareExchange64.nasm | 2 +-
MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.asm | 2 +-
MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.nasm | 2 +-
MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.asm | 2 +-
MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.nasm | 2 +-
10 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.asm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.asm
index e891922..262adeb 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.asm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.asm
@@ -27,7 +27,7 @@
;------------------------------------------------------------------------------
; UINT16
; EFIAPI
-; InterlockedCompareExchange16 (
+; InternalSyncCompareExchange16 (
; IN volatile UINT16 *Value,
; IN UINT16 CompareValue,
; IN UINT16 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.nasm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.nasm
index efe3249..eebed5a 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange16.nasm
@@ -28,7 +28,7 @@
;------------------------------------------------------------------------------
; UINT16
; EFIAPI
-; InterlockedCompareExchange16 (
+; InternalSyncCompareExchange16 (
; IN volatile UINT16 *Value,
; IN UINT16 CompareValue,
; IN UINT16 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.asm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.asm
index 269a3c7..711b399 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.asm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.asm
@@ -26,7 +26,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedCompareExchange32 (
+; InternalSyncCompareExchange32 (
; IN volatile UINT32 *Value,
; IN UINT32 CompareValue,
; IN UINT32 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.nasm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.nasm
index 31142d0..5ed4ba5 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange32.nasm
@@ -27,7 +27,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedCompareExchange32 (
+; InternalSyncCompareExchange32 (
; IN volatile UINT32 *Value,
; IN UINT32 CompareValue,
; IN UINT32 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.asm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.asm
index 80d03fd..be429d8 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.asm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.asm
@@ -26,7 +26,7 @@
;------------------------------------------------------------------------------
; UINT64
; EFIAPI
-; InterlockedCompareExchange64 (
+; InternalSyncCompareExchange64 (
; IN volatile UINT64 *Value,
; IN UINT64 CompareValue,
; IN UINT64 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.nasm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.nasm
index 819daed..2b268b6 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedCompareExchange64.nasm
@@ -27,7 +27,7 @@
;------------------------------------------------------------------------------
; UINT64
; EFIAPI
-; InterlockedCompareExchange64 (
+; InternalSyncCompareExchange64 (
; IN volatile UINT64 *Value,
; IN UINT64 CompareValue,
; IN UINT64 ExchangeValue
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.asm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.asm
index 23f03c4..4dc3886 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.asm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.asm
@@ -26,7 +26,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedDecrement (
+; InternalSyncDecrement (
; IN volatile UINT32 *Value
; );
;------------------------------------------------------------------------------
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.nasm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.nasm
index 780d902..60f4311 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedDecrement.nasm
@@ -27,7 +27,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedDecrement (
+; InternalSyncDecrement (
; IN volatile UINT32 *Value
; );
;------------------------------------------------------------------------------
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.asm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.asm
index 44f264f..fc086b6 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.asm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.asm
@@ -26,7 +26,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedIncrement (
+; InternalSyncIncrement (
; IN volatile UINT32 *Value
; );
;------------------------------------------------------------------------------
diff --git a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.nasm b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.nasm
index e1c70a4..7f877b5 100644
--- a/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.nasm
+++ b/MdePkg/Library/BaseSynchronizationLib/X64/InterlockedIncrement.nasm
@@ -27,7 +27,7 @@
;------------------------------------------------------------------------------
; UINT32
; EFIAPI
-; InterlockedIncrement (
+; InternalSyncIncrement (
; IN volatile UINT32 *Value
; );
;------------------------------------------------------------------------------
--
2.6.3.windows.1
next prev parent reply other threads:[~2016-11-17 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 19:34 [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile Michael Kinney
2016-11-17 19:34 ` [Patch v2 1/3] MdePkg/Include: Add volatile to SynchronizationLib parameters Michael Kinney
2016-11-17 19:34 ` [Patch v2 2/3] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs Michael Kinney
2016-11-17 19:34 ` Michael Kinney [this message]
2016-11-17 19:48 ` [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile Laszlo Ersek
2016-11-18 0:55 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479411282-10996-4-git-send-email-michael.d.kinney@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox