public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Liming Gao <liming.gao@intel.com>,
	Laszlo Ersek <lersek@redhat.com>, Andrew Fish <afish@apple.com>,
	Jeff Fan <jeff.fan@intel.com>
Subject: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4
Date: Thu, 17 Nov 2016 13:19:08 -0800	[thread overview]
Message-ID: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com> (raw)

Add volatile qualifier to mNumberToFinish to prevent GCC 5.4
compiler from optimizing away required logic in ACPI S3 resume.

Update TransferApToSafeState() use UINTN params to reduce the
number of type casts required in these calls and change
the NumberToFinish parameter from UINT32* to UINTN
NumberToFinishAddress to resolve compiler warnings from
a volatile pointer to a non-volatile pointer conversion.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (2):
  UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params
  UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish

 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c             | 10 +++++-----
 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 18 +++++++++---------
 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h    | 12 ++++++------
 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c  | 18 +++++++++---------
 4 files changed, 29 insertions(+), 29 deletions(-)

-- 
2.6.3.windows.1



             reply	other threads:[~2016-11-17 21:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 21:19 Michael Kinney [this message]
2016-11-17 21:19 ` [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params Michael Kinney
2016-11-17 21:19 ` [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish Michael Kinney
2016-11-17 23:46 ` [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 Laszlo Ersek
2016-11-18  0:48 ` Fan, Jeff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479417550-20400-1-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox