From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E42581EDC for ; Thu, 17 Nov 2016 13:19:08 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 17 Nov 2016 13:19:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,655,1473145200"; d="scan'208";a="5762347" Received: from mdkinney-mobl.amr.corp.intel.com ([10.232.100.14]) by orsmga002.jf.intel.com with ESMTP; 17 Nov 2016 13:19:12 -0800 From: Michael Kinney To: edk2-devel@lists.01.org Cc: Liming Gao , Laszlo Ersek , Andrew Fish , Jeff Fan Date: Thu, 17 Nov 2016 13:19:08 -0800 Message-Id: <1479417550-20400-1-git-send-email-michael.d.kinney@intel.com> X-Mailer: git-send-email 2.6.3.windows.1 Subject: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 21:19:08 -0000 Add volatile qualifier to mNumberToFinish to prevent GCC 5.4 compiler from optimizing away required logic in ACPI S3 resume. Update TransferApToSafeState() use UINTN params to reduce the number of type casts required in these calls and change the NumberToFinish parameter from UINT32* to UINTN NumberToFinishAddress to resolve compiler warnings from a volatile pointer to a non-volatile pointer conversion. Cc: Liming Gao Cc: Laszlo Ersek Cc: Andrew Fish Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney Michael Kinney (2): UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 10 +++++----- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 18 +++++++++--------- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 12 ++++++------ UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 18 +++++++++--------- 4 files changed, 29 insertions(+), 29 deletions(-) -- 2.6.3.windows.1