public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>
Subject: [PATCH v2] MdeModulePkg CapsuleApp: ASSERT to ensure 'CapsuleIndex' is not NULL
Date: Mon, 21 Nov 2016 15:50:24 +0800	[thread overview]
Message-ID: <1479714624-8356-1-git-send-email-hao.a.wu@intel.com> (raw)

Function GetVariable2() ensures its third (output) parameter will not be
NULL when the return status is EFI_SUCCESS.

This commit adds ASSERT as warnings for the case that will not happen.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 9291ba3..d09b938 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -285,6 +285,7 @@ DmpCapsuleStatusVariable (
              NULL
              );
   if (!EFI_ERROR(Status)) {
+    ASSERT (CapsuleIndex != NULL);
     CopyMem(CapsuleIndexData, CapsuleIndex, 11 * sizeof(CHAR16));
     CapsuleIndexData[11] = 0;
     Print(L"CapsuleMax - %s\n", CapsuleIndexData);
@@ -297,6 +298,7 @@ DmpCapsuleStatusVariable (
              NULL
              );
   if (!EFI_ERROR(Status)) {
+    ASSERT (CapsuleIndex != NULL);
     CopyMem(CapsuleIndexData, CapsuleIndex, 11 * sizeof(CHAR16));
     CapsuleIndexData[11] = 0;
     Print(L"CapsuleLast - %s\n", CapsuleIndexData);
-- 
1.9.5.msysgit.0



             reply	other threads:[~2016-11-21  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  7:50 Hao Wu [this message]
2016-11-21  7:57 ` [PATCH v2] MdeModulePkg CapsuleApp: ASSERT to ensure 'CapsuleIndex' is not NULL Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479714624-8356-1-git-send-email-hao.a.wu@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox