From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48EA881E89 for ; Tue, 22 Nov 2016 19:37:13 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 22 Nov 2016 19:37:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,684,1473145200"; d="scan'208";a="194735433" Received: from mswamyee-mobl2.amr.corp.intel.com (HELO localhost) ([10.252.141.16]) by fmsmga004.fm.intel.com with ESMTP; 22 Nov 2016 19:37:12 -0800 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk , lersek@redhat.com, edk2-devel@lists.01.org Message-ID: <147987223242.21600.11832738843366374732@jljusten-ivb> From: Jordan Justen In-Reply-To: <20161123023643.7106-2-konrad@kernel.org> Cc: xen-devel@lists.xenproject.org References: <9faa1698-7471-3f47-e552-8da23c0f0195@redhat.com> <20161123023643.7106-1-konrad@kernel.org> <20161123023643.7106-2-konrad@kernel.org> User-Agent: alot/0.3.7 Date: Tue, 22 Nov 2016 19:37:12 -0800 Subject: Re: [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 03:37:13 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2016-11-22 18:36:43, Konrad Rzeszutek Wilk wrote: > From Laszlo: > " change the catch-all (*) to GCC5, from GCC44 > - remove the (5.*.*) pattern from GCC49 > - add a branch (with multiple patterns if necessary) for gcc-4.3 and > earlier to exit with an error message / failure (those compiler > versions are unsupported)" For future reference, I'd suggest this for the formatting of your commit message body. v2: * Changes suggested by Laszlo: - change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - generate error for GCC < 4.4 Patch is Reviewed-by: Jordan Justen I'll let Laszlo take a look too. Thanks for the contribution! -Jordan > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D62 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Konrad Rzeszutek Wilk > --- > v1: First submission > v2: Redo it per Laszlo suggestion. > = > OvmfPkg/build.sh | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > = > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index eb5eb73..cab7c70 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -83,6 +83,13 @@ case `uname` in > Linux*) > gcc_version=3D$(gcc -v 2>&1 | tail -1 | awk '{print $3}') > case $gcc_version in > + 4.1.[0-0].*|4.2.*|4.3.*) > + echo OvmfPkg requires GCC4.4 or later > + exit 1 > + ;; > + 4.4.*) > + TARGET_TOOLS=3DGCC44 > + ;; > 4.5.*) > TARGET_TOOLS=3DGCC45 > ;; > @@ -95,11 +102,11 @@ case `uname` in > 4.8.*) > TARGET_TOOLS=3DGCC48 > ;; > - 4.9.*|4.1[0-9].*|5.*.*) > + 4.9.*) > TARGET_TOOLS=3DGCC49 > ;; > *) > - TARGET_TOOLS=3DGCC44 > + TARGET_TOOLS=3DGCC5 > ;; > esac > esac > -- = > 2.9.3 > = > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel