From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.75]) by mx.groups.io with SMTP id smtpd.web10.588.1626799472505803442 for ; Tue, 20 Jul 2021 09:44:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=xxaFjwox; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.75, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QcAwALX2/EJDKkm8x2H7v9sM9xa2HGtnbkRlLKA5VQRbZEwSLSvWMq6SwDzf71eaWk4j5VBxoEYJ6iEKVUSh5PCxxLF1DBNJOQQfp4BhHe8O85RR5hx9FZFK3TZ1xdh22dSSupU0h2wSTWJ9Lqkouv312kPg/l9iXxrNYAxgVzW7DCRiFdYBNMk9dKSThCHs/0dHJ4nlmPyvtAO9scXtoB042l001MgYs3XMLaDctK7soRQa2QDl5kkX96T3wuBsATWgGndiEaZz9WxAzRdOs/8YrQwJljSBSPN3U5yMa97Azy1+2qvWKfgDIzOZaCB5um5n44Jb6oOaO6AERqT0TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kAbHOJizsdU1k35zJtDMUpIG3e77qmiFwv1maWqZMc=; b=bZM5MKvuKxi4M+04KJ04wjkFTi4HDd1rRL+JdYQpb1Y0UVJctQADD8Yo+Z+TlwDXFeDivNQMsfK3pUHBqX1XEU8OeuIdpMs01o65aAI2llZzZbkvriEoJ2+2Mn7byT1bUMDl8ilDrWueFgQ6zD35K6bIp9hBbkeg+0WpYFSrnioXalOFI2XELgMakZ5iD3IGSZQ5Lr6Kb07R8/kxnnmUj9E+pzg+UnmYchCMju1SEq463LSoP2n+MieuXsdzY5UfQ1qIvKHjDu4ylSRPUykXnZUFxaGjnLETnJe5cwHiDW252tCJov6PN6RiCOCyAePIBojT1Db4ad7bNzYMAvE1eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1kAbHOJizsdU1k35zJtDMUpIG3e77qmiFwv1maWqZMc=; b=xxaFjwoxWXw/Cix0CQRv81s6ngrVZbmP/93wYME0EhOVrCzJKQQXY9SWY9SiKU6A1jY2VtInYaw9/sJjhXCC+/yISYClKoMeghv/6yH4vhAxPAqrWdBiEhzJ6a+VByJGVw/rjKijXxcUUvUGJt5wjNQEYCXszTm/h72IDxdEjbk= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN1PR12MB2416.namprd12.prod.outlook.com (2603:10b6:802:2f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.31; Tue, 20 Jul 2021 16:44:30 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::a8a9:2aac:4fd1:88fa]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::a8a9:2aac:4fd1:88fa%3]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 16:44:30 +0000 Cc: brijesh.singh@amd.com, Tobin Feldman-Fitzthum , Tobin Feldman-Fitzthum , Jim Cadden , James Bottomley , Hubertus Franke , Ard Biesheuvel , Jordan Justen , Ashish Kalra , Erdem Aktas , Jiewen Yao , Min Xu , Tom Lendacky Subject: Re: [PATCH v3 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page To: Dov Murik , devel@edk2.groups.io References: <20210720080401.3662854-1-dovmurik@linux.ibm.com> <20210720080401.3662854-9-dovmurik@linux.ibm.com> From: "Brijesh Singh" Message-ID: <147dcdae-7ea3-7714-15d3-901e68bf8cf5@amd.com> Date: Tue, 20 Jul 2021 11:44:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210720080401.3662854-9-dovmurik@linux.ibm.com> X-ClientProxiedBy: SN6PR05CA0013.namprd05.prod.outlook.com (2603:10b6:805:de::26) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.236.31.95] (165.204.77.1) by SN6PR05CA0013.namprd05.prod.outlook.com (2603:10b6:805:de::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.9 via Frontend Transport; Tue, 20 Jul 2021 16:44:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59c12952-5621-49e3-81b8-08d94b9da53c X-MS-TrafficTypeDiagnostic: SN1PR12MB2416: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZbhWpmXOa6GNFXFWnaPIFlg9UWWYfgGsOVZCWmMvOhFDN9X5CmQhSPu/gF2PhmekDsu7OzUm/yZNo9plgi+qnWgTwS9MgL0LC1q7RJz8odxKp64dxXTQgLqoa8iZdmJvRdQCnD4UgLSOoGHNbt2731o8+1F/bc8BfjZrGZLp+yoRyY4LEpZSF0SG3UG+IHtvaH676SGy0NwrWuzO0Jw2ID6aImaB5TAOF2vNZaD2p0eeQ1LM9Mu0JPFVxgExIGYZGYwhz9zRsQjdOGJEH/o2npzjIcJtoDIbvSvwsWvtimjuRX++DGqZXs5iUzWi1wuk2YICp6Lz60OFU7OxuNMg9pRbD1XH740HCwaSzihMk40+hMPiQx34lIg3iuoyYLBw7Yyjn/I+c5aJZ86EdbIH6yHB0lddkfRCVgjGfg27LKozagNhUT3VyCgPAecQt0cy+vwAy0/89ncKH88hCuuy4okrCUbRNob9jNaeUKKDjvJK+Zx+M2FaPVxert3ojRKqXbOfeNDylnnavM+D7dCOo022+Vl6MT+q3dJQy7635e87d3uv0HwjpgZHkCo4A/plK3lkUaNH3As9pCqmbzhARQ2Dp1kbL5CQrwh80f2ND88MNQSzL1UuQ70svJnnr50qUrcju6dqERLe54KQWz4+IxVrfWyPF/Up2h+EULNUJl2ner/FwckIHR9uudw1yueP9RfbSqNPSPKUHJa/w36pDPdyFR4hiaSDijqhJpfN3ivFzqSB9Oam2RvupDDS0U9XlPXqXrFNCeTYksUdXMLa21xPM+YVABqtO/e8Msx+DhKRP4fH84CJs7fIf6PxVMn7smRC9BISpGpiIWpF9mAmwQVuMuBuT2XzamHOIgewpJ8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(186003)(52116002)(6486002)(2906002)(66476007)(54906003)(53546011)(508600001)(66946007)(26005)(66556008)(31686004)(966005)(36756003)(31696002)(44832011)(16576012)(5660300002)(4744005)(7416002)(8936002)(316002)(4326008)(86362001)(38100700002)(8676002)(2616005)(38350700002)(956004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzVuQ1hCdW94MkFHQjNGeWpzQmJ1Qk01TU03TzArWC9VMjRxaFl2L1AvL2lI?= =?utf-8?B?K2kwSzhvekozNEFRUUhwK0lTelNwdUlsa0J4eGVSa0FKaU5vTjJyeXpYc09j?= =?utf-8?B?dEpvTDBoejFWUzBWQmVXcERXY0oyczhwdW5JSHU0MVprUzZTWkQ2K1pPWWNY?= =?utf-8?B?V1g4VGE5ekRGSUZFMW5LZGw1OGlUYUlVTWJlNEY0aXZmczI4ZGdQL1VvQUt3?= =?utf-8?B?Z3JSTjkxL2txYUt3TlE1RFdXdThDVHVKTEtVSXhROW1RN3ZoNFdDNmpaOXVq?= =?utf-8?B?ZitHTC9QNXlNSE9LZ0JrS2wzeitiOFU1azJ1T043NHBPa1lBd0owRDI0TlVi?= =?utf-8?B?L2NyOVc5ejlhVi9nOWxDaXBjOVhLeXJ5c2xWRWpiVzEvNllEZkczRk9qZXJs?= =?utf-8?B?M3d0OGdFYmJiSUZlQzVoQUQ1L1BRMWJIZnJ5ZWVlQWQwaENma0EyOUJxV1Y0?= =?utf-8?B?cDFPOEhLRk1YL0N4REJuUFhUeWhCeHY5QjhIOUt0eGdKUys2dzZmZ3lFdmpH?= =?utf-8?B?VWZIWkJGWm9OUlZZWEJpWmNNc1FuUlU5amZtNndGSUpWSnFTYnhaMitnNUJp?= =?utf-8?B?MnByWjlYVm9mdHdoWGxyZHoyY2JXRWorZGZnTmpjQ0dYbW1iY1MyaGhFK2Vx?= =?utf-8?B?V2JDYnBaZVVNaUxNTXp2aTJUYzFWOUdaZ1lheUV6bGwyblBIa3ArNlRjUFEw?= =?utf-8?B?aVRpZkt3bk90QTlZNEoxUWxtd2hpREFGZE1CTDcxVjlrZFRrWUs4d1lHR3V2?= =?utf-8?B?QlhLZEFsQ0ZkR3FYSldIaENhNGtUNFJoWDJsVkVHVmtoMmNuV1pkaERmeTRn?= =?utf-8?B?Y3lyMEhweXJwTzcycWZLcWFKMXljSFJFMkE5K3p2OFh2QTM3NXNxTGhVUXRI?= =?utf-8?B?TWgrNWY3Sy9aanI1dEJFV2wrUVZmUFZyZXZwdmxwc0FpU0czbkVtb1kzUGNC?= =?utf-8?B?WThkUExUcitPMkhlWkxTZkNxZElwSFFNZ2VvZjVWalBQejlvazNLektWV0xE?= =?utf-8?B?dW9NdThGd2FKQ2FoMEF3RGxjdzhpVkIvZHVnbUxkRHJSWUg2RXpuQjdMZ2JN?= =?utf-8?B?OGEzckl4TnloRStEVjZ6S0ZiSkg0eEdxYlk1d0E0aHZyZGRWeUlIUGhGWkg2?= =?utf-8?B?L0FjczJ6dzIzSWhDdVB4Z3REeCtodDI3UjFSb25oNlN4YlBVYmxFNGtpZ0Qy?= =?utf-8?B?cDVoUHpRRmFENWs0WkttR01aNVlyc2VHWFVQL3RTbFR4dDlSQmd1SXM2TytB?= =?utf-8?B?RG1IYjJmMVJVcThEWGtQZjdpc3RWSDVGUFF3SEpOalViZTFZOEtZejNxa1lU?= =?utf-8?B?RkNBVWMxNEtPckw1YjI5MjJML3M4amdOT2Z0aGh4TzRFTU5QTDJ3ZWtOcU9V?= =?utf-8?B?WEM0MjA3UkV4WHVkZnYrZlZTS05adHNFWit5UWdJcW9FeDAraFJPUFBKUkNo?= =?utf-8?B?ekIyVEg5T21pbXA3S0d3KzljMHo0QzY0UFdlYzhwd2o1akxxR2RIQ2FYcjhx?= =?utf-8?B?TVZQRHgzUk14MW5JWnVVRGx3MlBjMFZRZkdURHlObHBQNmRqaFY1YzFKZzNR?= =?utf-8?B?ZU5qN2dtUW1LWGxQU25QOUVhb2o1RmptN0MwVmZGUVFmSThWUzBIVW1HYWpL?= =?utf-8?B?eUJoUXFnVEZmUytkZHNtNWsya0thUTcraDZQNkdlVGRBMzFpcFZYQzNmNzJy?= =?utf-8?B?ZmxyeitNaVVCM2dJSmZtMGRMRHRxWGpCYmkraVNWZnRmZjNyUzNKZDR4aWJK?= =?utf-8?Q?KyeETS1vtdNQ947zcXD+sVJ0/BaF6ecVHXBje1D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59c12952-5621-49e3-81b8-08d94b9da53c X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 16:44:30.5359 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xfR4oLhR18OfUGFlQt/dzeD3ZsyqXeShN2N5CBEfHZHBclqpxqJlCJHB8IYrdRQvsgBSfMfB3RtZOkQNtC7Kcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB2416 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/20/21 3:03 AM, Dov Murik wrote: > Round up the size of the SEV launch secret area to a whole page, as > required by BuildMemoryAllocationHob. This will allow the secret > area defined in the MEMFD to take less than a whole 4KB page. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Ashish Kalra > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 > Signed-off-by: Dov Murik Reviewed-by: Brijesh Singh thanks