From: Jiewen Yao <jiewen.yao@intel.com>
To: edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>
Subject: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED.
Date: Tue, 29 Nov 2016 12:56:08 +0800 [thread overview]
Message-ID: <1480395368-13524-1-git-send-email-jiewen.yao@intel.com> (raw)
According to UEFI spec, unsupported function should return EFI_UNSUPPORTED
directly.
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
.../Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
index 642a99d..60490a4 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c
@@ -178,18 +178,6 @@ FmpGetImage (
IN OUT UINTN *ImageSize
)
{
- SYSTEM_FMP_PRIVATE_DATA *SystemFmpPrivate;
-
- if (Image == NULL || ImageSize == NULL) {
- return EFI_INVALID_PARAMETER;
- }
-
- SystemFmpPrivate = SYSTEM_FMP_PRIVATE_DATA_FROM_FMP(This);
-
- if (ImageIndex == 0 || ImageIndex > SystemFmpPrivate->DescriptorCount || ImageSize == NULL || Image == NULL) {
- return EFI_INVALID_PARAMETER;
- }
-
return EFI_UNSUPPORTED;
}
--
2.7.4.windows.1
next reply other threads:[~2016-11-29 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 4:56 Jiewen Yao [this message]
2016-11-29 5:13 ` [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480395368-13524-1-git-send-email-jiewen.yao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox