From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F0B6481C95 for ; Mon, 28 Nov 2016 20:56:14 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP; 28 Nov 2016 20:56:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,714,1473145200"; d="scan'208";a="36738586" Received: from jyao1-mobl.ccr.corp.intel.com ([10.239.193.79]) by fmsmga005.fm.intel.com with ESMTP; 28 Nov 2016 20:56:13 -0800 From: Jiewen Yao To: edk2-devel@lists.01.org Cc: Eric Dong Date: Tue, 29 Nov 2016 12:56:08 +0800 Message-Id: <1480395368-13524-1-git-send-email-jiewen.yao@intel.com> X-Mailer: git-send-email 2.7.4.windows.1 Subject: [PATCH] SignedCapsulePkg: GetImage() return EFI_UNSUPPORTED. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 04:56:15 -0000 According to UEFI spec, unsupported function should return EFI_UNSUPPORTED directly. Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- .../Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c index 642a99d..60490a4 100644 --- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c +++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCommonDxe.c @@ -178,18 +178,6 @@ FmpGetImage ( IN OUT UINTN *ImageSize ) { - SYSTEM_FMP_PRIVATE_DATA *SystemFmpPrivate; - - if (Image == NULL || ImageSize == NULL) { - return EFI_INVALID_PARAMETER; - } - - SystemFmpPrivate = SYSTEM_FMP_PRIVATE_DATA_FROM_FMP(This); - - if (ImageIndex == 0 || ImageIndex > SystemFmpPrivate->DescriptorCount || ImageSize == NULL || Image == NULL) { - return EFI_INVALID_PARAMETER; - } - return EFI_UNSUPPORTED; } -- 2.7.4.windows.1