[Patch 0/3] Vlv2TbltDevicePkg: Update build scripts

[Patch 0/3] Vlv2TbltDevicePkg: Update build scripts

[Michael Kinney]

Clean up MinnowMax build scripts removing extra null output
file and adding flags to enable multi-processor builds and 
report file generation.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>

Michael Kinney (3):
  Vlv2TbltDevicePkg: Fix typo in name of nul output file
  Vlv2TbltDevicePkg: Add /y flag to generate report files
  Vlv2TbltDevicePkg: Add /m flag for multi-processor build

 Vlv2TbltDevicePkg/Build_IFWI.bat | 10 ++++++++++
 Vlv2TbltDevicePkg/bld_vlv.bat    | 24 ++++++++++++++++++++----
 2 files changed, 30 insertions(+), 4 deletions(-)

-- 
2.6.3.windows.1

[Patch 1/3] Vlv2TbltDevicePkg: Fix typo in name of nul output file

[Michael Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=272

Fix typo in script file.  To prevent output from being
shown, then output file should be 'nul', not 'null'.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 Vlv2TbltDevicePkg/bld_vlv.bat | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.bat
index 6c53917..e21a6cf 100644
--- a/Vlv2TbltDevicePkg/bld_vlv.bat
+++ b/Vlv2TbltDevicePkg/bld_vlv.bat
@@ -68,11 +68,11 @@ if /i "%~1"=="/l" (
 if /i "%~1" == "/c" (
     echo Removing previous build files ...
     if exist build (
-        del /f/s/q build > null
+        del /f/s/q build > nul
         rmdir /s/q build
     )
     if exist conf\.cache (
-        del /f/s/q conf\.cache > null
+        del /f/s/q conf\.cache > nul
         rmdir /s/q conf\.cache
     )
     echo.
-- 
2.6.3.windows.1

[Patch 2/3] Vlv2TbltDevicePkg: Add /y flag to generate report files

[Michael Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=273

Update build script to generate a report file and put
both the report file and the log file in the directory
Vlv2TbltDevicePkg with an EDK2_Vlv2TbltDevicePkg prefix.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 Vlv2TbltDevicePkg/Build_IFWI.bat |  5 +++++
 Vlv2TbltDevicePkg/bld_vlv.bat    | 12 ++++++++++--
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/Vlv2TbltDevicePkg/Build_IFWI.bat b/Vlv2TbltDevicePkg/Build_IFWI.bat
index 0b50b79..d33f73e 100644
--- a/Vlv2TbltDevicePkg/Build_IFWI.bat
+++ b/Vlv2TbltDevicePkg/Build_IFWI.bat
@@ -40,6 +40,11 @@ if /i "%~1"=="/l" (
     shift
     goto OptLoop
 )
+if /i "%~1"=="/y" (
+    set Build_Flags=%Build_Flags% /y
+    shift
+    goto OptLoop
+)
 if /i "%~1" == "/c" (
     set Build_Flags=%Build_Flags% /c
     shift
diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.bat
index e21a6cf..e6e0bd0 100644
--- a/Vlv2TbltDevicePkg/bld_vlv.bat
+++ b/Vlv2TbltDevicePkg/bld_vlv.bat
@@ -29,7 +29,8 @@ set Arch=X64
 set Source=0
 
 :: Clean up previous build files.
-if exist %WORKSPACE%\edk2.log del %WORKSPACE%\edk2.log
+if exist %WORKSPACE%\%PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.log del %WORKSPACE%\%PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.log
+if exist %WORKSPACE%\%PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.report del %WORKSPACE%\%PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.report
 if exist %WORKSPACE%\unitool.log del %WORKSPACE%\unitool.log
 if exist %WORKSPACE%\Conf\target.txt del %WORKSPACE%\Conf\target.txt
 if exist %WORKSPACE%\Conf\tools_def.txt del %WORKSPACE%\Conf\tools_def.txt
@@ -61,7 +62,12 @@ copy /y nul %auto_config_inc% >nul
 if /i "%~1"=="/?" goto Usage
 
 if /i "%~1"=="/l" (
-    set Build_Flags=%Build_Flags% -j EDK2.log
+    set Build_Flags=%Build_Flags% -j %PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.log
+    shift
+    goto OptLoop
+)
+if /i "%~1"=="/y" (
+    set Build_Flags=%Build_Flags% -y %PLATFORM_PACKAGE%\EDK2_%PLATFORM_PACKAGE%.report
     shift
     goto OptLoop
 )
@@ -258,6 +264,8 @@ echo.
 echo Usage: bld_vlv.bat [options] PlatformType [Build Target]
 echo.
 echo    /c    CleanAll before building
+echo    /l    Generate build log file 
+echo    /y    Generate build report file 
 echo    /IA32 Set Arch to IA32 (default: X64)
 echo    /X64  Set Arch to X64 (default: X64)
 echo.
-- 
2.6.3.windows.1

[Patch 3/3] Vlv2TbltDevicePkg: Add /m flag for multi-processor build

[Michael Kinney]

https://bugzilla.tianocore.org/show_bug.cgi?id=274

Add support for multi-processor builds using a /m flag.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 Vlv2TbltDevicePkg/Build_IFWI.bat | 5 +++++
 Vlv2TbltDevicePkg/bld_vlv.bat    | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/Vlv2TbltDevicePkg/Build_IFWI.bat b/Vlv2TbltDevicePkg/Build_IFWI.bat
index d33f73e..ac22a76 100644
--- a/Vlv2TbltDevicePkg/Build_IFWI.bat
+++ b/Vlv2TbltDevicePkg/Build_IFWI.bat
@@ -45,6 +45,11 @@ if /i "%~1"=="/y" (
     shift
     goto OptLoop
 )
+if /i "%~1"=="/m" (
+    set Build_Flags=%Build_Flags% /m
+    shift
+    goto OptLoop
+)
 if /i "%~1" == "/c" (
     set Build_Flags=%Build_Flags% /c
     shift
diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.bat
index e6e0bd0..0193d4c 100644
--- a/Vlv2TbltDevicePkg/bld_vlv.bat
+++ b/Vlv2TbltDevicePkg/bld_vlv.bat
@@ -71,6 +71,13 @@ if /i "%~1"=="/y" (
     shift
     goto OptLoop
 )
+if /i "%~1"=="/m" (
+    if defined NUMBER_OF_PROCESSORS (
+        set /a build_threads=%NUMBER_OF_PROCESSORS%+1
+    )
+    shift
+    goto OptLoop
+)
 if /i "%~1" == "/c" (
     echo Removing previous build files ...
     if exist build (
@@ -266,6 +273,7 @@ echo.
 echo    /c    CleanAll before building
 echo    /l    Generate build log file 
 echo    /y    Generate build report file 
+echo    /m    Enable multi-processor build
 echo    /IA32 Set Arch to IA32 (default: X64)
 echo    /X64  Set Arch to X64 (default: X64)
 echo.
-- 
2.6.3.windows.1

Re: [Patch 0/3] Vlv2TbltDevicePkg: Update build scripts

[Yao, Jiewen]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, November 30, 2016 6:13 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wei, David
> <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
> Subject: [Patch 0/3] Vlv2TbltDevicePkg: Update build scripts
> 
> Clean up MinnowMax build scripts removing extra null output
> file and adding flags to enable multi-processor builds and
> report file generation.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: David Wei <david.wei@intel.com>
> Cc: Mang Guo <mang.guo@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> 
> Michael Kinney (3):
>   Vlv2TbltDevicePkg: Fix typo in name of nul output file
>   Vlv2TbltDevicePkg: Add /y flag to generate report files
>   Vlv2TbltDevicePkg: Add /m flag for multi-processor build
> 
>  Vlv2TbltDevicePkg/Build_IFWI.bat | 10 ++++++++++
>  Vlv2TbltDevicePkg/bld_vlv.bat    | 24 ++++++++++++++++++++----
>  2 files changed, 30 insertions(+), 4 deletions(-)
> 
> --
> 2.6.3.windows.1