From: Dandan Bi <dandan.bi@intel.com>
To: edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>
Subject: [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used
Date: Mon, 5 Dec 2016 19:40:55 +0800 [thread overview]
Message-ID: <1480938055-45116-1-git-send-email-dandan.bi@intel.com> (raw)
https://bugzilla.tianocore.org/show_bug.cgi?id=280
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
index 451fd03..06e682a 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c
@@ -3533,10 +3533,11 @@ SubmitForSystem (
VOID
)
{
EFI_STATUS Status;
LIST_ENTRY *Link;
+ LIST_ENTRY *FormLink;
LIST_ENTRY *StorageLink;
FORMSET_STORAGE *FormSetStorage;
FORM_BROWSER_FORM *Form;
FORM_BROWSER_FORMSET *LocalFormSet;
UINT32 UserSelection;
@@ -3623,14 +3624,14 @@ SubmitForSystem (
FormSetStorage->SyncConfigRequest = NULL;
}
}
}
- Link = GetFirstNode (&LocalFormSet->FormListHead);
- while (!IsNull (&LocalFormSet->FormListHead, Link)) {
- Form = FORM_BROWSER_FORM_FROM_LINK (Link);
- Link = GetNextNode (&LocalFormSet->FormListHead, Link);
+ FormLink = GetFirstNode (&LocalFormSet->FormListHead);
+ while (!IsNull (&LocalFormSet->FormListHead, FormLink)) {
+ Form = FORM_BROWSER_FORM_FROM_LINK (FormLink);
+ FormLink = GetNextNode (&LocalFormSet->FormListHead, FormLink);
//
// Call callback with Changed type to inform the driver.
//
SendDiscardInfoToDriver (LocalFormSet, Form);
}
--
1.9.5.msysgit.1
next reply other threads:[~2016-12-05 11:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 11:40 Dandan Bi [this message]
2016-12-06 7:25 ` [patch] MdeModulePkg/SetupBrowserDxe: Fix incorrect local variable used Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480938055-45116-1-git-send-email-dandan.bi@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox