From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel@lists.01.org, ruiyu.ni@intel.com
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers
Date: Thu, 8 Dec 2016 08:17:22 +0000 [thread overview]
Message-ID: <1481185042-23873-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
Add missing EFIAPI modifiers to the functions that are exposed via the
PCI I/O protocol.
At the same time, add a missing UINT8 cast which breaks the build on
Visual Studio.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
Apologies for the breakage.
MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 21 +++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
index 1e7244a129ae..56482e3353c0 100644
--- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
+++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
@@ -43,7 +43,7 @@ GetBarResource (
return EFI_NOT_FOUND;
}
- BarIndex -= Dev->BarOffset;
+ BarIndex -= (UINT8)Dev->BarOffset;
for (Desc = Dev->Device->Resources;
Desc->Desc != ACPI_END_TAG_DESCRIPTOR;
@@ -61,6 +61,7 @@ GetBarResource (
STATIC
EFI_STATUS
+EFIAPI
PciIoPollMem (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -78,6 +79,7 @@ PciIoPollMem (
STATIC
EFI_STATUS
+EFIAPI
PciIoPollIo (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -95,6 +97,7 @@ PciIoPollIo (
STATIC
EFI_STATUS
+EFIAPI
PciIoMemRW (
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
IN UINTN Count,
@@ -145,6 +148,7 @@ PciIoMemRW (
STATIC
EFI_STATUS
+EFIAPI
PciIoMemRead (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -211,6 +215,7 @@ PciIoMemRead (
STATIC
EFI_STATUS
+EFIAPI
PciIoMemWrite (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -277,6 +282,7 @@ PciIoMemWrite (
STATIC
EFI_STATUS
+EFIAPI
PciIoIoRead (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -292,6 +298,7 @@ PciIoIoRead (
STATIC
EFI_STATUS
+EFIAPI
PciIoIoWrite (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -307,6 +314,7 @@ PciIoIoWrite (
STATIC
EFI_STATUS
+EFIAPI
PciIoPciRead (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -342,6 +350,7 @@ PciIoPciRead (
STATIC
EFI_STATUS
+EFIAPI
PciIoPciWrite (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -369,6 +378,7 @@ PciIoPciWrite (
STATIC
EFI_STATUS
+EFIAPI
PciIoCopyMem (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_WIDTH Width,
@@ -385,6 +395,7 @@ PciIoCopyMem (
STATIC
EFI_STATUS
+EFIAPI
CoherentPciIoMap (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_OPERATION Operation,
@@ -450,6 +461,7 @@ CoherentPciIoMap (
STATIC
EFI_STATUS
+EFIAPI
CoherentPciIoUnmap (
IN EFI_PCI_IO_PROTOCOL *This,
IN VOID *Mapping
@@ -472,6 +484,7 @@ CoherentPciIoUnmap (
STATIC
EFI_STATUS
+EFIAPI
CoherentPciIoAllocateBuffer (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_ALLOCATE_TYPE Type,
@@ -513,6 +526,7 @@ CoherentPciIoAllocateBuffer (
STATIC
EFI_STATUS
+EFIAPI
CoherentPciIoFreeBuffer (
IN EFI_PCI_IO_PROTOCOL *This,
IN UINTN Pages,
@@ -526,6 +540,7 @@ CoherentPciIoFreeBuffer (
STATIC
EFI_STATUS
+EFIAPI
PciIoFlush (
IN EFI_PCI_IO_PROTOCOL *This
)
@@ -535,6 +550,7 @@ PciIoFlush (
STATIC
EFI_STATUS
+EFIAPI
PciIoGetLocation (
IN EFI_PCI_IO_PROTOCOL *This,
OUT UINTN *SegmentNumber,
@@ -560,6 +576,7 @@ PciIoGetLocation (
STATIC
EFI_STATUS
+EFIAPI
PciIoAttributes (
IN EFI_PCI_IO_PROTOCOL *This,
IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation,
@@ -616,6 +633,7 @@ PciIoAttributes (
STATIC
EFI_STATUS
+EFIAPI
PciIoGetBarAttributes (
IN EFI_PCI_IO_PROTOCOL *This,
IN UINT8 BarIndex,
@@ -666,6 +684,7 @@ PciIoGetBarAttributes (
STATIC
EFI_STATUS
+EFIAPI
PciIoSetBarAttributes (
IN EFI_PCI_IO_PROTOCOL *This,
IN UINT64 Attributes,
--
2.7.4
next reply other threads:[~2016-12-08 8:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 8:17 Ard Biesheuvel [this message]
2016-12-08 9:25 ` [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers Bi, Dandan
2016-12-09 14:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481185042-23873-1-git-send-email-ard.biesheuvel@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox