* [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
@ 2016-12-08 17:21 Tapan Shah
2016-12-08 22:07 ` Carsey, Jaben
0 siblings, 1 reply; 3+ messages in thread
From: Tapan Shah @ 2016-12-08 17:21 UTC (permalink / raw)
To: edk2-devel; +Cc: jaben.carsey, Tapan Shah
Adding a missing header line for 'cls -sfo' command
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Tapan Shah <tapandshah@hpe.com>
---
ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c | 1 +
.../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni | 1 +
2 files changed, 2 insertions(+)
diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
index de79b82..7e7d58d 100644
--- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
+++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
@@ -82,6 +82,7 @@ ShellCommandRunCls (
} else {
Background = (gST->ConOut->Mode->Attribute >> 4) & 0x7;
Foreground = gST->ConOut->Mode->Attribute & 0x0F;
+ ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER), gShellLevel3HiiHandle, L"cls");
ShellPrintHiiEx (
-1,
-1,
diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni
index bbcb752..b027c67 100644
--- a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni
@@ -43,6 +43,7 @@
#string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not found - '%H%s%N'\r\n"
#string STR_GEN_FILE_NF #language en-US "%H%s%N: File not found - '%H%s%N'\r\n"
#string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a directory\r\n"
+#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n"
#string STR_NO_SCRIPT #language en-US "The command '%H%s%N' is not allowed outside of a script\r\n"
#string STR_TYP_ERROR #language en-US "%H%s%N: Operation was not successful on '%H%s%N'\r\n"
--
1.9.5.msysgit.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
2016-12-08 17:21 [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command Tapan Shah
@ 2016-12-08 22:07 ` Carsey, Jaben
2016-12-09 1:35 ` Ni, Ruiyu
0 siblings, 1 reply; 3+ messages in thread
From: Carsey, Jaben @ 2016-12-08 22:07 UTC (permalink / raw)
To: Tapan Shah, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Ray, can you push with your other stuff?
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Thursday, December 8, 2016 9:21 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Tapan Shah
> <tapandshah@hpe.com>
> Subject: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
> Importance: High
>
> Adding a missing header line for 'cls -sfo' command
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com>
> ---
> ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c | 1 +
> .../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni | 1
> +
> 2 files changed, 2 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> index de79b82..7e7d58d 100644
> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> @@ -82,6 +82,7 @@ ShellCommandRunCls (
> } else {
> Background = (gST->ConOut->Mode->Attribute >> 4) & 0x7;
> Foreground = gST->ConOut->Mode->Attribute & 0x0F;
> + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER),
> gShellLevel3HiiHandle, L"cls");
> ShellPrintHiiEx (
> -1,
> -1,
> diff --git
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> index bbcb752..b027c67 100644
> ---
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> +++
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> @@ -43,6 +43,7 @@
> #string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not
> found - '%H%s%N'\r\n"
> #string STR_GEN_FILE_NF #language en-US "%H%s%N: File not found -
> '%H%s%N'\r\n"
> #string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a
> directory\r\n"
> +#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n"
> #string STR_NO_SCRIPT #language en-US "The command '%H%s%N' is
> not allowed outside of a script\r\n"
>
> #string STR_TYP_ERROR #language en-US "%H%s%N: Operation was not
> successful on '%H%s%N'\r\n"
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
2016-12-08 22:07 ` Carsey, Jaben
@ 2016-12-09 1:35 ` Ni, Ruiyu
0 siblings, 0 replies; 3+ messages in thread
From: Ni, Ruiyu @ 2016-12-09 1:35 UTC (permalink / raw)
To: Carsey, Jaben, Tapan Shah, edk2-devel@lists.01.org
done.
Regards,
Ray
From: Carsey, Jaben
Sent: Friday, December 9, 2016 6:07 AM
To: Tapan Shah <tapandshah@hpe.com>; edk2-devel@lists.01.org
Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
Subject: RE: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>
Ray, can you push with your other stuff?
> -----Original Message-----
> From: Tapan Shah [mailto:tapandshah@hpe.com]
> Sent: Thursday, December 8, 2016 9:21 AM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Carsey, Jaben <jaben.carsey@intel.com<mailto:jaben.carsey@intel.com>>; Tapan Shah
> <tapandshah@hpe.com<mailto:tapandshah@hpe.com>>
> Subject: [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command
> Importance: High
>
> Adding a missing header line for 'cls -sfo' command
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Tapan Shah <tapandshah@hpe.com<mailto:tapandshah@hpe.com>>
> ---
> ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c | 1 +
> .../Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.uni | 1
> +
> 2 files changed, 2 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> index de79b82..7e7d58d 100644
> --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Cls.c
> @@ -82,6 +82,7 @@ ShellCommandRunCls (
> } else {
> Background = (gST->ConOut->Mode->Attribute >> 4) & 0x7;
> Foreground = gST->ConOut->Mode->Attribute & 0x0F;
> + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_GEN_SFO_HEADER),
> gShellLevel3HiiHandle, L"cls");
> ShellPrintHiiEx (
> -1,
> -1,
> diff --git
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> index bbcb752..b027c67 100644
> ---
> a/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> +++
> b/ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.
> uni
> @@ -43,6 +43,7 @@
> #string STR_GEN_DIR_NF #language en-US "%H%s%N: Directory not
> found - '%H%s%N'\r\n"
> #string STR_GEN_FILE_NF #language en-US "%H%s%N: File not found -
> '%H%s%N'\r\n"
> #string STR_GEN_IS_DIR #language en-US "%H%s%N: '%H%s%N' is a
> directory\r\n"
> +#string STR_GEN_SFO_HEADER #language en-US "ShellCommand,"%s"\r\n"
> #string STR_NO_SCRIPT #language en-US "The command '%H%s%N' is
> not allowed outside of a script\r\n"
>
> #string STR_TYP_ERROR #language en-US "%H%s%N: Operation was not
> successful on '%H%s%N'\r\n"
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-09 1:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-08 17:21 [PATCH] ShellPkg: Add missing header line for SFO flag in 'cls' command Tapan Shah
2016-12-08 22:07 ` Carsey, Jaben
2016-12-09 1:35 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox