public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
@ 2016-12-14  5:19 Liming Gao
  2016-12-14  5:41 ` Yao, Jiewen
  0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2016-12-14  5:19 UTC (permalink / raw)
  To: edk2-devel; +Cc: Jiewen Yao

Change structure value assignment with CopyMem() API.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
index 7592def..c95a22d 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
@@ -1,6 +1,6 @@
 /** @file
 
-Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -134,7 +134,10 @@ EbcDebuggerPushCallstackDest (
     //
     ASSERT (mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_TRACE_MAX].Type == Type);
     for (Index = 0; Index < EFI_DEBUGGER_CALLSTACK_MAX; Index++) {
-      mDebuggerPrivate.CallStackEntry[Index] = mDebuggerPrivate.CallStackEntry[Index + 1];
+      CopyMem (&mDebuggerPrivate.CallStackEntry[Index],
+               &mDebuggerPrivate.CallStackEntry[Index + 1],
+               sizeof (mDebuggerPrivate.CallStackEntry[Index])
+               );
     }
     mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_CALLSTACK_MAX - 1].DestAddress = DestEntry;
     mDebuggerPrivate.CallStackEntryCount = EFI_DEBUGGER_CALLSTACK_MAX;
-- 
2.8.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
  2016-12-14  5:19 [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure Liming Gao
@ 2016-12-14  5:41 ` Yao, Jiewen
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2016-12-14  5:41 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, December 14, 2016 1:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
> 
> Change structure value assignment with CopyMem() API.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> index 7592def..c95a22d 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -134,7 +134,10 @@ EbcDebuggerPushCallstackDest (
>      //
>      ASSERT
> (mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_TRACE_MAX].Type == Type);
>      for (Index = 0; Index < EFI_DEBUGGER_CALLSTACK_MAX; Index++) {
> -      mDebuggerPrivate.CallStackEntry[Index] =
> mDebuggerPrivate.CallStackEntry[Index + 1];
> +      CopyMem (&mDebuggerPrivate.CallStackEntry[Index],
> +               &mDebuggerPrivate.CallStackEntry[Index + 1],
> +               sizeof (mDebuggerPrivate.CallStackEntry[Index])
> +               );
>      }
>      mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_CALLSTACK_MAX -
> 1].DestAddress = DestEntry;
>      mDebuggerPrivate.CallStackEntryCount =
> EFI_DEBUGGER_CALLSTACK_MAX;
> --
> 2.8.0.windows.1



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-12-14  5:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-14  5:19 [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure Liming Gao
2016-12-14  5:41 ` Yao, Jiewen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox