[PATCH 0/4] Fix GCC build warnings for BaseTools

[Heyi Guo <heyi.guo@linaro.org>]

There are 28 warnings when I build BaseTools using gcc (version 4.8.4
(Ubuntu 4.8.4-2ubuntu1~14.04.3)). Below patches are to fix these build
warnings. I don't have a visual studio environment to test the build;
sorry for not testing the patches entirely.

There are still 10 warnings which I'm not very clear how to fix; could
anyone please help to fix them:

  ../support/set/set.c:557:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
  VfrSyntax.g, line 1830: warning: predicate: LT(i) missing, bad, or with i=0; assuming i=1
  VfrSyntax.g, line 1835: warning: predicate: LT(i) missing, bad, or with i=0; assuming i=1
  VfrSyntax.g, line 3266: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  VfrSyntax.g, line 3275: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  VfrSyntax.g, line 3284: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  VfrSyntax.g, line 3294: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  VfrSyntax.g, line 3324: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  VfrSyntax.g, line 3333: warning: alts 1 and 2 of {..} ambiguous upon ( ";" RefreshGuid GuidOp Locked Image EndIf InconsistentIf DisableIf SuppressIf Default GrayOutIf )
  ../support/set/set.c:557:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]

Heyi Guo (4):
  BaseTools: fix format-security build warnings
  BaseTools: fix format type build warnings
  BaseTools: fix write-strings build warnings
  BaseTools: fix unused-result build warnings

 BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c  | 16 ++++++++--------
 BaseTools/Source/C/VfrCompile/Pccts/antlr/fset2.c |  2 +-
 BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c   |  6 +++---
 BaseTools/Source/C/VfrCompile/Pccts/antlr/lex.c   |  8 ++++----
 BaseTools/Source/C/VfrCompile/VfrFormPkg.cpp      |  2 +-
 BaseTools/Source/C/VfrCompile/VfrUtilityLib.cpp   |  4 +++-
 6 files changed, 20 insertions(+), 18 deletions(-)

-- 
1.9.1