From: Hao Wu <hao.a.wu@intel.com>
To: edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <liming.gao@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: [PATCH v2 0/6] Refine code logics to prevent possible mis-reports by static code checkers
Date: Fri, 16 Dec 2016 11:37:37 +0800 [thread overview]
Message-ID: <1481859463-10536-1-git-send-email-hao.a.wu@intel.com> (raw)
V2:
Patch 1 of the V1 series has an issue that APIs [Ascii]StrnLens will
access (MaxSize + 1) characters of String if there is no null character in
the first MaxSize characters in String. However, according to the comments
of these APIs, only MaxSize characters of String shall be accessed.
V2 addresses this issue. Also, 'r-b' tags have been added to the reviewed
patches of the series.
V1:
The series refines the loop logic (e.g. for, while) of some functions to
be more straightforward. This will help to prevent some possible
mis-reports by static code checkers
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Hao Wu (6):
MdePkg/BaseLib: Refine (Ascii)StrnLenS functions logic
MdePkg/BaseLib: Add an additional check within (Ascii)StrnCmp
MdePkg/MemoryLib: Refine InternalMemSetMem16|32|64 functions logic
MdeModulePkg/DxeNetLib: Rewrite NetblockChecksum function logic
MdeModulePkg/UefiPxeBcDxe: Refine the CvtNum function logic
NetworkPkg: Refine UintnToAscDecWithFormat functions logic
MdeModulePkg/Library/DxeNetLib/NetBuffer.c | 16 ++++++++--------
.../Universal/Network/UefiPxeBcDxe/PxeBcSupport.c | 5 ++---
MdePkg/Library/BaseLib/SafeString.c | 16 ++++++++++++----
MdePkg/Library/BaseLib/String.c | 4 +++-
MdePkg/Library/BaseMemoryLib/MemLibGeneric.c | 18 +++++++++---------
MdePkg/Library/PeiMemoryLib/MemLibGeneric.c | 18 +++++++++---------
MdePkg/Library/UefiMemoryLib/MemLibGeneric.c | 18 +++++++++---------
NetworkPkg/HttpBootDxe/HttpBootSupport.c | 5 ++---
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 5 ++---
9 files changed, 56 insertions(+), 49 deletions(-)
--
1.9.5.msysgit.0
next reply other threads:[~2016-12-16 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 3:37 Hao Wu [this message]
2016-12-16 3:37 ` [PATCH v2 1/6] MdePkg/BaseLib: Refine (Ascii)StrnLenS functions logic Hao Wu
2016-12-22 3:28 ` Gao, Liming
2016-12-16 3:37 ` [PATCH v2 2/6] MdePkg/BaseLib: Add an additional check within (Ascii)StrnCmp Hao Wu
2016-12-16 3:37 ` [PATCH v2 3/6] MdePkg/MemoryLib: Refine InternalMemSetMem16|32|64 functions logic Hao Wu
2016-12-16 3:37 ` [PATCH v2 4/6] MdeModulePkg/DxeNetLib: Rewrite NetblockChecksum function logic Hao Wu
2016-12-16 3:37 ` [PATCH v2 5/6] MdeModulePkg/UefiPxeBcDxe: Refine the CvtNum " Hao Wu
2016-12-16 3:37 ` [PATCH v2 6/6] NetworkPkg: Refine UintnToAscDecWithFormat functions logic Hao Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481859463-10536-1-git-send-email-hao.a.wu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox