From: Dandan Bi <dandan.bi@intel.com>
To: edk2-devel@lists.01.org
Cc: Jiewen Yao <jiewen.yao@intel.com>
Subject: [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules
Date: Mon, 19 Dec 2016 15:20:19 +0800 [thread overview]
Message-ID: <1482132023-10416-5-git-send-email-dandan.bi@intel.com> (raw)
In-Reply-To: <1482132023-10416-1-git-send-email-dandan.bi@intel.com>
For variable name, it should contain lower case characters.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 8 ++++----
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 18 +++++++++---------
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
index 9c5707e..ba62c6a 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c
@@ -164,21 +164,21 @@ DebuggerDisplaySymbolAccrodingToAddress (
EDBPrint (L" Address Type Symbol\n");
EDBPrint (L" ================== ==== ========\n");
// EDBPrint (L" 0xFFFFFFFF00000000 ( F) TestMain\n");
EDBPrint (
L" 0x%016lx %s %a\n",
- (UINT64)Entry->RVA + Object->BaseAddress,
+ (UINT64)Entry->Rva + Object->BaseAddress,
EdbSymbolTypeToStr (Entry->Type),
Entry->Name
);
} else {
EDBPrint (L" Address Type Symbol\n");
EDBPrint (L" ========== ==== ========\n");
// EDBPrint (L" 0xFFFF0000 ( F) TestMain\n");
EDBPrint (
L" 0x%08x %s %a\n",
- Entry->RVA + Object->BaseAddress,
+ Entry->Rva + Object->BaseAddress,
EdbSymbolTypeToStr (Entry->Type),
Entry->Name
);
}
@@ -271,19 +271,19 @@ DebuggerDisplaySymbolAccrodingToName (
}
if (sizeof(UINTN) == sizeof(UINT64)) {
EDBPrint (
L" 0x%016lx %s %a (%a)\n",
- (UINT64)Entry->RVA + Object->BaseAddress,
+ (UINT64)Entry->Rva + Object->BaseAddress,
EdbSymbolTypeToStr (Entry->Type),
Entry->Name,
Entry->ObjName
);
} else {
EDBPrint (
L" 0x%08x %s %a (%a)\n",
- Entry->RVA + Object->BaseAddress,
+ Entry->Rva + Object->BaseAddress,
EdbSymbolTypeToStr (Entry->Type),
Entry->Name,
Entry->ObjName
);
}
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h
index 2a54be1..d452b2b 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h
@@ -88,11 +88,11 @@ typedef enum {
EfiDebuggerSymbolTypeMax,
} EFI_DEBUGGER_SYMBOL_TYPE;
typedef struct {
CHAR8 Name[EFI_DEBUGGER_SYMBOL_NAME_MAX];
- UINTN RVA;
+ UINTN Rva;
EFI_DEBUGGER_SYMBOL_TYPE Type;
CHAR8 ObjName[EFI_DEBUGGER_SYMBOL_NAME_MAX];
CHAR8 *CodBuffer;
UINTN CodBufferSize;
UINTN FuncOffsetBase;
diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c
index e6a677d..4e640ea 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c
@@ -65,11 +65,11 @@ EdbLoadSymbolSingleEntry (
//
AsciiStrnCpyS (Entry->Name, sizeof(Entry->Name), Name, sizeof(Entry->Name) - 1);
if (ObjName != NULL) {
AsciiStrnCpyS (Entry->ObjName, sizeof(Entry->ObjName), ObjName, sizeof(Entry->ObjName) - 1);
}
- Entry->RVA = Address % EFI_DEBUGGER_DEFAULT_LINK_IMAGEBASE;
+ Entry->Rva = Address % EFI_DEBUGGER_DEFAULT_LINK_IMAGEBASE;
Entry->Type = Type;
//
// Increase Count
//
@@ -513,29 +513,29 @@ EbdFindSymbolAddress (
//
// Go through each entry
//
Entry = Object->Entry;
for (SubIndex = 0; SubIndex < Object->EntryCount; SubIndex++, Entry++) {
- if (Address != Entry->RVA + Object->BaseAddress) {
+ if (Address != Entry->Rva + Object->BaseAddress) {
//
// Check for nearest address
//
- if (Address > Entry->RVA + Object->BaseAddress) {
+ if (Address > Entry->Rva + Object->BaseAddress) {
//
// Record it if Current RVA < Address
//
- if (CandidateLowerAddress < Entry->RVA + Object->BaseAddress) {
- CandidateLowerAddress = Entry->RVA + Object->BaseAddress;
+ if (CandidateLowerAddress < Entry->Rva + Object->BaseAddress) {
+ CandidateLowerAddress = Entry->Rva + Object->BaseAddress;
LowEntry = Entry;
LowObject = Object;
}
} else {
//
// Record it if Current RVA > Address
//
- if (CandidateUpperAddress > Entry->RVA + Object->BaseAddress) {
- CandidateUpperAddress = Entry->RVA + Object->BaseAddress;
+ if (CandidateUpperAddress > Entry->Rva + Object->BaseAddress) {
+ CandidateUpperAddress = Entry->Rva + Object->BaseAddress;
UpperEntry = Entry;
UpperObject = Object;
}
}
continue;
@@ -1710,11 +1710,11 @@ FindSymbolStr (
Entry = Object[ObjectIndex].Entry;
for (EntryIndex = 0; EntryIndex < Object[ObjectIndex].EntryCount; EntryIndex++) {
//
// if Address match, return Name
//
- if (Address == (Entry[EntryIndex].RVA + Object[ObjectIndex].BaseAddress)) {
+ if (Address == (Entry[EntryIndex].Rva + Object[ObjectIndex].BaseAddress)) {
return Entry[EntryIndex].Name;
}
}
}
@@ -2217,11 +2217,11 @@ Symboltoi (
return EFI_NO_MAPPING;
} else {
//
// record Address
//
- *Address = (Entry[EntryIndex].RVA + Object[ObjectIndex].BaseAddress);
+ *Address = (Entry[EntryIndex].Rva + Object[ObjectIndex].BaseAddress);
}
}
}
}
--
1.9.5.msysgit.1
next prev parent reply other threads:[~2016-12-19 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 7:20 [patch 0/8] Fix coding style issues Dandan Bi
2016-12-19 7:20 ` [patch 1/8] SecurityPkg/FmpAuthenticationLib: Fix Guid format issues Dandan Bi
2016-12-19 7:32 ` Yao, Jiewen
2016-12-19 7:20 ` [patch 2/8] IntelSiliconPkg: Fix " Dandan Bi
2016-12-19 7:32 ` Yao, Jiewen
2016-12-19 7:20 ` [patch 3/8] MdeModulePkg/CapsuleApp: Fix Guid " Dandan Bi
2016-12-19 7:32 ` Yao, Jiewen
2016-12-19 7:20 ` Dandan Bi [this message]
2016-12-19 7:33 ` [patch 4/8] MdeModulePkg/EbcDxe: Make variable name follow rules Yao, Jiewen
2016-12-19 7:20 ` [patch 5/8] MdeModulePkg/EmmcDxe: Avoid Non-Boolean type used as Boolean Dandan Bi
2016-12-19 7:38 ` Tian, Feng
2016-12-19 7:20 ` [patch 6/8] MdeModulePkg/TerminalDxe: Initialize variable after declaration Dandan Bi
2016-12-20 1:14 ` Tian, Feng
2016-12-19 7:20 ` [patch 7/8] MdeModulePkg/SataControllerDxe: Fix coding style issue Dandan Bi
2016-12-20 1:18 ` Tian, Feng
2016-12-19 7:20 ` [patch 8/8] MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues Dandan Bi
2016-12-19 13:44 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482132023-10416-5-git-send-email-dandan.bi@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox