* [patch 1/2] UefiCpuPkg: Add Pcd info to uni file @ 2016-12-20 7:53 Dandan Bi 2016-12-20 7:53 ` [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues Dandan Bi 2016-12-20 16:59 ` [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Kinney, Michael D 0 siblings, 2 replies; 4+ messages in thread From: Dandan Bi @ 2016-12-20 7:53 UTC (permalink / raw) To: edk2-devel; +Cc: Michael Kinney, Jeff Fan Add PcdCpuSmmStmExceptionStackSize/PcdCpuMsegSize prompt and help string to uni file Cc: Michael Kinney <michael.d.kinney@intel.com> Cc: Jeff Fan <jeff.fan@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan.bi@intel.com> --- UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index 298ed7e..f4dd339 100644 --- a/UefiCpuPkg/UefiCpuPkg.uni +++ b/UefiCpuPkg/UefiCpuPkg.uni @@ -153,5 +153,13 @@ "If enabled, SMM will not use on-demand paging. SMM will build static page table for all memory.<BR><BR>\n" "This flag only impacts X64 build, because SMM alway builds static page table for IA32.\n" "TRUE - SMM uses static page table for all memory.<BR>\n" "FALSE - SMM uses static page table for below 4G memory and use on-demand paging for above 4G memory.<BR>" +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStmExceptionStackSize_PROMPT #language en-US "STM exception stack size." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStmExceptionStackSize_HELP #language en-US "Specifies buffer size in bytes for STM exception stack. The value should be a multiple of 4KB." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_PROMPT #language en-US "MSEG size." + +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_HELP #language en-US "Specifies buffer size in bytes of MSEG. The value should be a multiple of 4KB." + -- 1.9.5.msysgit.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues 2016-12-20 7:53 [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Dandan Bi @ 2016-12-20 7:53 ` Dandan Bi 2016-12-20 16:59 ` Kinney, Michael D 2016-12-20 16:59 ` [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Kinney, Michael D 1 sibling, 1 reply; 4+ messages in thread From: Dandan Bi @ 2016-12-20 7:53 UTC (permalink / raw) To: edk2-devel; +Cc: Michael Kinney, Jeff Fan Cc: Michael Kinney <michael.d.kinney@intel.com> Cc: Jeff Fan <jeff.fan@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi <dandan.bi@intel.com> --- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 2 +- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c | 2 +- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c index 31d73cd..079baa4 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c @@ -41,11 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #define SMM_FEATURES_LIB_IA32_MCA_CAP 0x17D #define SMM_CODE_ACCESS_CHK_BIT BIT58 /** Internal worker function that is called to complete CPU initialization at the - end of SmmCpuFeaturesInitializeProcessor() + end of SmmCpuFeaturesInitializeProcessor(). **/ VOID FinishSmmCpuFeaturesInitializeProcessor ( VOID diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c index e872eec..5276856 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c @@ -16,11 +16,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. #include <PiSmm.h> #include <Library/SmmCpuFeaturesLib.h> /** Internal worker function that is called to complete CPU initialization at the - end of SmmCpuFeaturesInitializeProcessor() + end of SmmCpuFeaturesInitializeProcessor(). **/ VOID FinishSmmCpuFeaturesInitializeProcessor ( VOID diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c index 59c49e3..bb123ba 100644 --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c @@ -188,11 +188,11 @@ SmmCpuFeaturesLibStmConstructor ( return EFI_SUCCESS; } /** Internal worker function that is called to complete CPU initialization at the - end of SmmCpuFeaturesInitializeProcessor() + end of SmmCpuFeaturesInitializeProcessor(). **/ VOID FinishSmmCpuFeaturesInitializeProcessor ( VOID -- 1.9.5.msysgit.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues 2016-12-20 7:53 ` [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues Dandan Bi @ 2016-12-20 16:59 ` Kinney, Michael D 0 siblings, 0 replies; 4+ messages in thread From: Kinney, Michael D @ 2016-12-20 16:59 UTC (permalink / raw) To: Bi, Dandan, edk2-devel@lists.01.org, Kinney, Michael D; +Cc: Fan, Jeff Reviewed-by: Michael Kinney <michael.d.kinney@intel.com> > -----Original Message----- > From: Bi, Dandan > Sent: Monday, December 19, 2016 11:53 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Fan, Jeff > <jeff.fan@intel.com> > Subject: [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues > > Cc: Michael Kinney <michael.d.kinney@intel.com> > Cc: Jeff Fan <jeff.fan@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan.bi@intel.com> > --- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 2 +- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c | 2 +- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > index 31d73cd..079baa4 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > @@ -41,11 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > #define SMM_FEATURES_LIB_IA32_MCA_CAP 0x17D > #define SMM_CODE_ACCESS_CHK_BIT BIT58 > > /** > Internal worker function that is called to complete CPU initialization at the > - end of SmmCpuFeaturesInitializeProcessor() > + end of SmmCpuFeaturesInitializeProcessor(). > > **/ > VOID > FinishSmmCpuFeaturesInitializeProcessor ( > VOID > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c > index e872eec..5276856 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c > @@ -16,11 +16,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > #include <PiSmm.h> > #include <Library/SmmCpuFeaturesLib.h> > > /** > Internal worker function that is called to complete CPU initialization at the > - end of SmmCpuFeaturesInitializeProcessor() > + end of SmmCpuFeaturesInitializeProcessor(). > > **/ > VOID > FinishSmmCpuFeaturesInitializeProcessor ( > VOID > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > index 59c49e3..bb123ba 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c > @@ -188,11 +188,11 @@ SmmCpuFeaturesLibStmConstructor ( > return EFI_SUCCESS; > } > > /** > Internal worker function that is called to complete CPU initialization at the > - end of SmmCpuFeaturesInitializeProcessor() > + end of SmmCpuFeaturesInitializeProcessor(). > > **/ > VOID > FinishSmmCpuFeaturesInitializeProcessor ( > VOID > -- > 1.9.5.msysgit.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch 1/2] UefiCpuPkg: Add Pcd info to uni file 2016-12-20 7:53 [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Dandan Bi 2016-12-20 7:53 ` [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues Dandan Bi @ 2016-12-20 16:59 ` Kinney, Michael D 1 sibling, 0 replies; 4+ messages in thread From: Kinney, Michael D @ 2016-12-20 16:59 UTC (permalink / raw) To: Bi, Dandan, edk2-devel@lists.01.org, Kinney, Michael D; +Cc: Fan, Jeff Reviewed-by: Michael Kinney <michael.d.kinney@intel.com> > -----Original Message----- > From: Bi, Dandan > Sent: Monday, December 19, 2016 11:53 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Fan, Jeff > <jeff.fan@intel.com> > Subject: [patch 1/2] UefiCpuPkg: Add Pcd info to uni file > > Add PcdCpuSmmStmExceptionStackSize/PcdCpuMsegSize prompt and help > string to uni file > > Cc: Michael Kinney <michael.d.kinney@intel.com> > Cc: Jeff Fan <jeff.fan@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi <dandan.bi@intel.com> > --- > UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni > index 298ed7e..f4dd339 100644 > --- a/UefiCpuPkg/UefiCpuPkg.uni > +++ b/UefiCpuPkg/UefiCpuPkg.uni > @@ -153,5 +153,13 @@ > > "If enabled, SMM will not use on-demand paging. SMM will build static page table > for all memory.<BR><BR>\n" > > "This flag only impacts X64 build, because SMM alway builds static page table for > IA32.\n" > > "TRUE - SMM uses static page table for all memory.<BR>\n" > > "FALSE - SMM uses static page table for below 4G memory and use on-demand paging > for above 4G memory.<BR>" > > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStmExceptionStackSize_PROMPT > #language en-US "STM exception stack size." > + > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStmExceptionStackSize_HELP > #language en-US "Specifies buffer size in bytes for STM exception stack. The > value should be a multiple of 4KB." > + > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_PROMPT #language en-US > "MSEG size." > + > +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuMsegSize_HELP #language en-US > "Specifies buffer size in bytes of MSEG. The value should be a multiple of 4KB." > + > -- > 1.9.5.msysgit.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-20 16:59 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-12-20 7:53 [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Dandan Bi 2016-12-20 7:53 ` [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues Dandan Bi 2016-12-20 16:59 ` Kinney, Michael D 2016-12-20 16:59 ` [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Kinney, Michael D
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox