public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Star Zeng <star.zeng@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Ruiyu Ni <Ruiyu.ni@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>,
	Feng Tian <feng.tian@intel.com>, Jeff Fan <jeff.fan@intel.com>,
	Michael Zimmermann <sigmaepsilon92@gmail.com>
Subject: [PATCH V2 0/5] Execute key notify function at TPL_CALLBACK
Date: Fri, 23 Dec 2016 16:13:07 +0800	[thread overview]
Message-ID: <1482480792-35264-1-git-send-email-star.zeng@intel.com> (raw)

Current implementation of keyboard driver executes key notify
function in TimerHandler at TPL_NOTIFY. The code change is to
make key notify function executed at TPL_CALLBACK to reduce
the time occupied at TPL_NOTIFY.

The code will signal KeyNotify process event if the key pressed
matches any key registered and insert the KeyData to the EFI Key
queue for notify, then the KeyNotify process handler will invoke
key notify functions at TPL_CALLBACK.

It can also address the problem raised at
https://lists.01.org/pipermail/edk2-devel/2016-December/005644.html

V2:
Based on the comments from Ruiyu, Ni,
add comments before calling Enqueue() to make the code more clear
and eliminate the call to IsQueueEmpty() in KeyNotifyProcessHandler().

Cc: Ruiyu Ni <Ruiyu.ni@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Michael Zimmermann <sigmaepsilon92@gmail.com>

Star Zeng (5):
  MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK
  MdeModulePkg TerminalDxe: Execute key notify func at TPL_CALLBACK
  MdeModulePkg Ps2KbDxe: Execute key notify func at TPL_CALLBACK
  IntelFrameworkModulePkg Ps2KbDxe: Execute key notify func at
    TPL_CALLBACK
  IntelFrameworkModulePkg KbDxe: Execute key notify func at TPL_CALLBACK

 .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c         |  14 +-
 .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c          |  51 +++++-
 .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c           |  23 ++-
 .../Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h           |  15 ++
 .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.c       |  86 +++++++++-
 .../Csm/BiosThunk/KeyboardDxe/BiosKeyboard.h       |  17 +-
 .../Bus/Isa/Ps2KeyboardDxe/Ps2KbdCtrller.c         |  12 +-
 MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c |  49 ++++++
 MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.c  |  20 +++
 MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2Keyboard.h  |  15 ++
 MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c             |  68 +++++++-
 MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h             |  17 +-
 MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c           |  12 +-
 .../Universal/Console/TerminalDxe/Terminal.c       |  25 ++-
 .../Universal/Console/TerminalDxe/Terminal.h       |  80 ++++++++-
 .../Universal/Console/TerminalDxe/TerminalConIn.c  | 186 ++++++++++++++++++++-
 16 files changed, 665 insertions(+), 25 deletions(-)

-- 
2.7.0.windows.1



             reply	other threads:[~2016-12-23  8:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23  8:13 Star Zeng [this message]
2016-12-23  8:13 ` [PATCH V2 1/5] MdeModulePkg UsbKbDxe: Execute key notify func at TPL_CALLBACK Star Zeng
2016-12-23  8:13 ` [PATCH V2 2/5] MdeModulePkg TerminalDxe: " Star Zeng
2016-12-23  8:13 ` [PATCH V2 3/5] MdeModulePkg Ps2KbDxe: " Star Zeng
2016-12-23  8:13 ` [PATCH V2 4/5] IntelFrameworkModulePkg " Star Zeng
2016-12-23  8:13 ` [PATCH V2 5/5] IntelFrameworkModulePkg KbDxe: " Star Zeng
2016-12-23  9:51 ` [PATCH V2 0/5] Execute key notify function " Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482480792-35264-1-git-send-email-star.zeng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox