From: Jordan Justen <jordan.l.justen@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
"edk2-devel-01" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script
Date: Wed, 04 Jan 2017 14:01:53 -0800 [thread overview]
Message-ID: <148356731339.32514.12895184140738530358@jljusten-ivb> (raw)
In-Reply-To: <401681ee-93af-e490-88aa-28291bf41c1a@redhat.com>
On 2017-01-04 03:19:20, Laszlo Ersek wrote:
> On 01/04/17 02:30, Jordan Justen wrote:
> > On 2016-12-02 02:48:44, Laszlo Ersek wrote:
> >> @@ -362,7 +390,9 @@ OnS3SaveStateInstalled (
> >> S3SaveState,
> >> EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCODE,
> >> EfiBootScriptWidthUint16,
> >> - (UINT64)POWER_MGMT_REGISTER_Q35 (ICH9_GEN_PMCON_1),
> >> + ConvertPciLibToEfiPciAddress (
> >> + POWER_MGMT_REGISTER_Q35 (ICH9_GEN_PMCON_1)
> >
> > I think we should just add a EFI_POWER_MGMT_REGISTER_Q35 macro.
>
> I thought of that, but I didn't want to use the EFI_ prefix for a macro
> that has nothing to do with the UEFI / PI specs. Can you suggest an
> alternative name? Perhaps POWER_MGMT_REGISTER_Q35_EFI?
Good point. Yeah, that name seems fine to me.
-Jordan
next prev parent reply other threads:[~2017-01-04 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 10:48 [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script Laszlo Ersek
2017-01-03 11:41 ` Laszlo Ersek
2017-01-04 1:30 ` Jordan Justen
2017-01-04 11:19 ` Laszlo Ersek
2017-01-04 22:01 ` Jordan Justen [this message]
2017-01-05 1:03 ` Yao, Jiewen
2017-01-05 1:45 ` Yao, Jiewen
2017-01-05 11:47 ` Laszlo Ersek
2017-01-05 13:09 ` Yao, Jiewen
2017-01-05 13:15 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148356731339.32514.12895184140738530358@jljusten-ivb \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox