From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jordan.l.justen@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 307C4818E8
 for <edk2-devel@lists.01.org>; Wed,  4 Jan 2017 14:01:54 -0800 (PST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 04 Jan 2017 14:01:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,317,1477983600"; d="scan'208";a="918997526"
Received: from bpbrunin-mobl.amr.corp.intel.com (HELO localhost)
 ([10.252.133.160])
 by orsmga003.jf.intel.com with ESMTP; 04 Jan 2017 14:01:53 -0800
MIME-Version: 1.0
To: Laszlo Ersek <lersek@redhat.com>, "edk2-devel-01" <edk2-devel@lists.01.org>
Message-ID: <148356731339.32514.12895184140738530358@jljusten-ivb>
From: Jordan Justen <jordan.l.justen@intel.com>
In-Reply-To: <401681ee-93af-e490-88aa-28291bf41c1a@redhat.com>
References: <20161202104844.6093-1-lersek@redhat.com>
 <148349340944.16413.4237312013765520247@jljusten-ivb>
 <401681ee-93af-e490-88aa-28291bf41c1a@redhat.com>
User-Agent: alot/0.3.7
Date: Wed, 04 Jan 2017 14:01:53 -0800
Subject: Re: [PATCH] OvmfPkg/SmmControl2Dxe: correct PCI_CONFIG_READ_WRITE in S3 boot script
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 22:01:54 -0000
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On 2017-01-04 03:19:20, Laszlo Ersek wrote:
> On 01/04/17 02:30, Jordan Justen wrote:
> > On 2016-12-02 02:48:44, Laszlo Ersek wrote:
> >> @@ -362,7 +390,9 @@ OnS3SaveStateInstalled (
> >>                            S3SaveState,
> >>                            EFI_BOOT_SCRIPT_PCI_CONFIG_READ_WRITE_OPCOD=
E,
> >>                            EfiBootScriptWidthUint16,
> >> -                          (UINT64)POWER_MGMT_REGISTER_Q35 (ICH9_GEN_P=
MCON_1),
> >> +                          ConvertPciLibToEfiPciAddress (
> >> +                            POWER_MGMT_REGISTER_Q35 (ICH9_GEN_PMCON_1)
> > =

> > I think we should just add a EFI_POWER_MGMT_REGISTER_Q35 macro.
> =

> I thought of that, but I didn't want to use the EFI_ prefix for a macro
> that has nothing to do with the UEFI / PI specs. Can you suggest an
> alternative name? Perhaps POWER_MGMT_REGISTER_Q35_EFI?

Good point. Yeah, that name seems fine to me.

-Jordan