public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Leo Duran <leo.duran@amd.com>
To: <edk2-devel@lists.01.org>
Cc: <brijesh.singh@amd.com>, <lersek@redhat.com>,
	<jordan.l.justen@intel.com>,  <jeff.fan@intel.com>,
	<michael.d.kinney@intel.com>, <liming.gao@intel.com>,
	<maurice.ma@intel.com>, <prince.agyeman@intel.com>,
	<ruiyu.ni@intel.com>, <kelly.steele@intel.com>,
	<david.wei@intel.com>, <mang.guo@intel.com>,
	Leo Duran <leo.duran@amd.com>
Subject: [PATCH v4 0/9] BaseIoFifoLib
Date: Fri, 6 Jan 2017 10:24:50 -0600	[thread overview]
Message-ID: <1483719899-16125-1-git-send-email-leo.duran@amd.com> (raw)

The UefiCpuPkg/CpuIo2Dxe driver and the QemuCfgLib library have duplicate
implementations of I/O Fifo routines. The patch series moves the I/O Fifo
routines into a common BaseIofifoLib library supporting IA32 and X64
architectures under MdePkg.

The intent of this patch series is twofold:
1) Consolidate I/O Fifo routines into a common BaseIofifoLib library.
2) Allow override of BaseIofifoLib for specific platform implementations.
For example, the OVMF package can provide its own version of BaseIoFifoLib
to support Secure Encrypted Virtualization (SEV) guests, since SEV does not
support string I/O instructions (rep ins/outs), and requires unrolled loops
of single in/out instructions.

Changes since v3:
- Split patch (1 to 6 patches) to modify .DSC files per top-level package

Brijesh Singh (9):
  MdePkg: Add BaseIoFifoLib library
  CorebootPayloadPkg: Modify .DSC files that include
    UefiCpuPkg/CpuIo2Dxe
  DuetPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
  OvmfPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
  QuarkPlatformPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
  UefiCpuPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
  Vlv2TbltDevicePkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
  Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library.
  Modify QemuFwCfgLib to use new BaseIoFifoLib library.

 CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc      |   3 +
 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc   |   3 +
 DuetPkg/DuetPkgIa32.dsc                            |   2 +
 DuetPkg/DuetPkgX64.dsc                             |   2 +
 MdePkg/Include/Library/IoFifoLib.h                 | 176 +++++++++++++
 MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf     |  44 ++++
 .../Library/BaseIoFifoLib}/Ia32/IoFifo.asm         | 280 ++++++++++-----------
 .../Library/BaseIoFifoLib}/Ia32/IoFifo.nasm        | 272 ++++++++++----------
 .../Library/BaseIoFifoLib}/X64/IoFifo.asm          | 252 +++++++++----------
 .../Library/BaseIoFifoLib}/X64/IoFifo.nasm         | 250 +++++++++---------
 MdePkg/MdePkg.dec                                  |   4 +
 MdePkg/MdePkg.dsc                                  |   2 +
 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm  |  55 ----
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c        |  55 +---
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf      |   8 +-
 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf   |   8 +-
 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm   |  52 ----
 OvmfPkg/OvmfPkgIa32.dsc                            |   2 +
 OvmfPkg/OvmfPkgIa32X64.dsc                         |   2 +
 OvmfPkg/OvmfPkgX64.dsc                             |   2 +
 QuarkPlatformPkg/Quark.dsc                         |   2 +
 QuarkPlatformPkg/QuarkMin.dsc                      |   2 +
 UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.c                   |   3 +-
 UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.h                   |   3 +
 UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf                 |  12 +-
 UefiCpuPkg/UefiCpuPkg.dsc                          |   2 +
 Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |   2 +
 Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |   2 +
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |   2 +
 29 files changed, 795 insertions(+), 709 deletions(-)
 create mode 100644 MdePkg/Include/Library/IoFifoLib.h
 create mode 100644 MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf
 rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.asm (96%)
 rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoFifoLib}/Ia32/IoFifo.nasm (96%)
 rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.asm (97%)
 rename {UefiCpuPkg/CpuIo2Dxe => MdePkg/Library/BaseIoFifoLib}/X64/IoFifo.nasm (97%)
 delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/Ia32/IoLibExAsm.nasm
 delete mode 100644 OvmfPkg/Library/QemuFwCfgLib/X64/IoLibExAsm.nasm

-- 
1.9.1



             reply	other threads:[~2017-01-06 16:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 16:24 Leo Duran [this message]
2017-01-06 16:24 ` [PATCH v4 1/9] MdePkg: Add BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 2/9] CorebootPayloadPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe Leo Duran
2017-01-10  3:59   ` Ma, Maurice
2017-01-06 16:24 ` [PATCH v4 3/9] DuetPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 4/9] OvmfPkg: " Leo Duran
2017-01-06 16:35   ` Laszlo Ersek
2017-01-06 16:24 ` [PATCH v4 5/9] QuarkPlatformPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 6/9] UefiCpuPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 7/9] Vlv2TbltDevicePkg: " Leo Duran
2017-01-09  2:16   ` Wei, David
2017-01-06 16:24 ` [PATCH v4 8/9] Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 9/9] Modify QemuFwCfgLib " Leo Duran
2017-01-06 16:40   ` Laszlo Ersek
2017-01-06 16:30 ` [PATCH v4 0/9] BaseIoFifoLib Duran, Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483719899-16125-1-git-send-email-leo.duran@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox