Re: [PATCH v3 0/4] BaseIoFifoLib

[Jordan Justen <jordan.l.justen@intel.com>]

On 2017-01-06 07:23:47, Duran, Leo wrote:
> 
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Friday, January 06, 2017 5:12 AM
> > To: Gao, Liming <liming.gao@intel.com>; Duran, Leo <leo.duran@amd.com>;
> > edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
> > Cc: Singh, Brijesh <brijesh.singh@amd.com>; Justen, Jordan L
> > <jordan.l.justen@intel.com>; Fan, Jeff <jeff.fan@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Ma, Maurice
> > <maurice.ma@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>;
> > Ni, Ruiyu <ruiyu.ni@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Wei,
> > David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
> > Subject: Re: [PATCH v3 0/4] BaseIoFifoLib
> > 
> > On 01/06/17 07:02, Gao, Liming wrote:
> > > Leo:
> > > FifoIo is one width type of EFI_CPU_IO_PROTOCOL_WIDTH. So, how about
> > > add new APIs into IoLib together with other Io APIs? If so, no new
> > > library class is required. Platform DSC files are not required to be
> > > changed.
> > 
> > But then all of the IoLib instances will have to be extended too:
> > 
> > IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf
> > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
> > MdePkg/Library/DxeIoLibCpuIo2/DxeIoLibCpuIo2.inf
> > MdePkg/Library/DxeIoLibEsal/DxeIoLibEsal.inf
> > MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf
> > MdePkg/Library/SmmIoLibSmmCpuIo2/SmmIoLibSmmCpuIo2.inf
> > 
> > Thanks,
> > Laszlo
> > 
> [Duran, Leo] Correct.
> As I mentioned, one of the reasons for the new IoFifo library is to
> be able to override it without having to duplicate the complete
> IoLib.
> 

I agree with Liming about adding the functions to IoLib instead.

Perhaps a PCD could be added to control if rep i/o instructions are
used.

-Jordan