From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 08AC581A4F for ; Fri, 6 Jan 2017 16:49:40 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 06 Jan 2017 16:49:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,326,1477983600"; d="scan'208";a="27193087" Received: from bpbrunin-mobl.amr.corp.intel.com (HELO localhost) ([10.252.133.160]) by orsmga002.jf.intel.com with ESMTP; 06 Jan 2017 16:49:39 -0800 MIME-Version: 1.0 To: "Duran, Leo" , "'Laszlo Ersek'" , "Gao, Liming" , "edk2-devel@lists.01.org" Message-ID: <148375017874.13659.3185969071926290103@jljusten-ivb> From: Jordan Justen In-Reply-To: Cc: "Singh, Brijesh" , "Fan, Jeff" , "Kinney, Michael D" , "Ma, Maurice" , "Agyeman, Prince" , "Ni, Ruiyu" , "Steele, Kelly" , "Wei, David" , "Guo, Mang" References: <1483652965-14357-1-git-send-email-leo.duran@amd.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6CA2BD@shsmsx102.ccr.corp.intel.com> <9bf84287-cdec-b5c0-26c6-16f5cd1e453f@redhat.com> User-Agent: alot/0.3.7 Date: Fri, 06 Jan 2017 16:49:38 -0800 Subject: Re: [PATCH v3 0/4] BaseIoFifoLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2017 00:49:40 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 2017-01-06 07:23:47, Duran, Leo wrote: > = > = > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Friday, January 06, 2017 5:12 AM > > To: Gao, Liming ; Duran, Leo ; > > edk2-devel@lists.01.org > > Cc: Singh, Brijesh ; Justen, Jordan L > > ; Fan, Jeff ; Kinney, > > Michael D ; Ma, Maurice > > ; Agyeman, Prince ; > > Ni, Ruiyu ; Steele, Kelly ;= Wei, > > David ; Guo, Mang > > Subject: Re: [PATCH v3 0/4] BaseIoFifoLib > > = > > On 01/06/17 07:02, Gao, Liming wrote: > > > Leo: > > > FifoIo is one width type of EFI_CPU_IO_PROTOCOL_WIDTH. So, how about > > > add new APIs into IoLib together with other Io APIs? If so, no new > > > library class is required. Platform DSC files are not required to be > > > changed. > > = > > But then all of the IoLib instances will have to be extended too: > > = > > IntelFrameworkPkg/Library/DxeIoLibCpuIo/DxeIoLibCpuIo.inf > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > > MdePkg/Library/DxeIoLibCpuIo2/DxeIoLibCpuIo2.inf > > MdePkg/Library/DxeIoLibEsal/DxeIoLibEsal.inf > > MdePkg/Library/PeiIoLibCpuIo/PeiIoLibCpuIo.inf > > MdePkg/Library/SmmIoLibSmmCpuIo2/SmmIoLibSmmCpuIo2.inf > > = > > Thanks, > > Laszlo > > = > [Duran, Leo] Correct. > As I mentioned, one of the reasons for the new IoFifo library is to > be able to override it without having to duplicate the complete > IoLib. > = I agree with Liming about adding the functions to IoLib instead. Perhaps a PCD could be added to control if rep i/o instructions are used. -Jordan