From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3DB6B817B5 for ; Sun, 8 Jan 2017 21:40:24 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 08 Jan 2017 21:40:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1109828131" Received: from shwdeopenpsi068.ccr.corp.intel.com ([10.239.9.9]) by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2017 21:40:22 -0800 From: Star Zeng To: edk2-devel@lists.01.org Cc: Star Zeng , Chao Zhang Date: Mon, 9 Jan 2017 13:40:19 +0800 Message-Id: <1483940419-139088-1-git-send-email-star.zeng@intel.com> X-Mailer: git-send-email 2.7.0.windows.1 Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 05:40:24 -0000 Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 6 +++--- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c index 34828eed7d64..050e43a3371d 100644 --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c @@ -137,7 +137,7 @@ InitializeTcg2VersionInfo ( } } else { // - // EFI variable doesn't exist. + // EFI variable doesn't exist or variable size is not expected. // // @@ -182,7 +182,7 @@ InitializeTcg2VersionInfo ( // // Get the PCD value again. // If the PCD value is not equal to the value in variable, - // the PCD is not DynamicHii type and maps to the setup option. + // the PCD is not DynamicHii type and does not map to the setup option. // PcdTcg2PpiVersion = 0; CopyMem ( @@ -191,7 +191,7 @@ InitializeTcg2VersionInfo ( AsciiStrSize ((CHAR8 *) PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer)) ); if (PcdTcg2PpiVersion != Tcg2Version.PpiVersion) { - DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and maps to TCG2_VERSION.PpiVersion\n")); + DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and does not map to TCG2_VERSION.PpiVersion\n")); DEBUG ((DEBUG_WARN, "WARNING: The TCG2 PPI version configuring from setup page will not work\n")); } diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c index 4432daea81b6..f4a07c642009 100644 --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c @@ -489,7 +489,7 @@ Tcg2VersionInfoCallback ( // Get the PCD value after EFI_BROWSER_ACTION_SUBMITTED, // the SetVariable to TCG2_VERSION_NAME should have been done. // If the PCD value is not equal to the value set to variable, - // the PCD is not DynamicHii type and maps to the setup option. + // the PCD is not DynamicHii type and does not map to the setup option. // PcdTcg2PpiVersion = 0; CopyMem ( @@ -501,7 +501,7 @@ Tcg2VersionInfoCallback ( CreatePopUp ( EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, - L"WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and maps to this option!", + L"WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and does not map to this option!", L"The version configuring by this setup option will not work!", NULL ); -- 2.7.0.windows.1