From: "Marvin Häuser" <mhaeuser@posteo.de>
To: Ni, Ray <ray.ni@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data
Date: Fri, 10 Feb 2023 00:47:29 -0800 [thread overview]
Message-ID: <14845.1676018849905103136@groups.io> (raw)
In-Reply-To: <MN6PR11MB824437D2DB9DA2BC9C0063D68CDE9@MN6PR11MB8244.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
Hi Ray and Jiaxin,
Quick reminder that [1] invokes undefined behaviour and [0] is not legal C, but a compiler extension. The canonical way is a flexible array member using [].
Off-topic and nitpicking, but I started wondering why so many structures are packed. For UEFI, packing would only help saving RAM when there‘s actual padding (unlike this case, where there isn‘t). All architectures require natural data alignment („unless specifies otherwise“), so there should be no compatibility concerns for structures specific to UEFI and UEFI PI ever. When considering ABIs outside UEFI, even then natural alignment is the strictest realistically possible outside super niche platforms, as even executable formats don‘t pack their structures (this structure also is inherently naturally aligned).
Best regards,
Marvin
[-- Attachment #2: Type: text/html, Size: 884 bytes --]
next prev parent reply other threads:[~2023-02-10 8:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 6:05 [PATCH v4 0/5] Simplify SMM Relocation Process Wu, Jiaxin
2023-02-10 6:05 ` [PATCH v4 1/5] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call Wu, Jiaxin
2023-02-10 7:10 ` [edk2-devel] " Ni, Ray
2023-02-10 6:05 ` [PATCH v4 2/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-02-10 7:14 ` Ni, Ray
2023-02-10 7:30 ` Wu, Jiaxin
2023-02-10 8:47 ` Marvin Häuser [this message]
2023-02-10 11:23 ` Gerd Hoffmann
2023-02-10 11:56 ` Ni, Ray
2023-02-10 12:32 ` Gerd Hoffmann
2023-02-10 13:12 ` Ni, Ray
2023-02-13 2:37 ` Wu, Jiaxin
2023-02-10 6:05 ` [PATCH v4 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-02-10 10:00 ` [edk2-devel] " Marvin Häuser
2023-02-13 2:18 ` Wu, Jiaxin
2023-02-10 11:26 ` Gerd Hoffmann
2023-02-10 12:37 ` [edk2-devel] " Ni, Ray
2023-02-10 13:02 ` Gerd Hoffmann
2023-02-13 4:15 ` Wu, Jiaxin
2023-02-13 9:42 ` Ni, Ray
2023-02-10 12:34 ` Ni, Ray
2023-02-10 6:05 ` [PATCH v4 4/5] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration Wu, Jiaxin
2023-02-10 12:39 ` Ni, Ray
2023-02-10 6:05 ` [PATCH v4 5/5] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not Wu, Jiaxin
2023-02-10 11:28 ` Gerd Hoffmann
2023-02-10 12:56 ` [edk2-devel] [PATCH v4 0/5] Simplify SMM Relocation Process Ni, Ray
2023-02-13 2:19 ` Wu, Jiaxin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14845.1676018849905103136@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox