[PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X

[PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X

[Star Zeng]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=344

SlotType AGP8X was added in SMBIOS spec 2.3.4, but the decoding
of it is missing. I found it when I am adding SMBIOS spec 3.1.0
support.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index b802c5450907..bb7a19b04170 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -2,7 +2,7 @@
   Build a table, each item is (Key, Info) pair.
   And give a interface of query a string out of a table.
 
-  Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2005 - 2017, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -1263,6 +1263,10 @@ TABLE_ITEM  SystemSlotTypeTable[] = {
     L"PCI-X"
   },
   {
+    0x13,
+    L"AGP 8X"
+  },
+  {
     0xA0,
     L"PC-98/C20 "
   },
-- 
2.7.0.windows.1

Re: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Monday, January 16, 2017 7:23 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>;
> Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [PATCH] ShellPkg SmbiosView: Add missing decoding of SlotType AGP8X
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=344
> 
> SlotType AGP8X was added in SMBIOS spec 2.3.4, but the decoding of it is
> missing. I found it when I am adding SMBIOS spec 3.1.0 support.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 6
> +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> index b802c5450907..bb7a19b04170 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> +++ c
> @@ -2,7 +2,7 @@
>    Build a table, each item is (Key, Info) pair.
>    And give a interface of query a string out of a table.
> 
> -  Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2005 - 2017, Intel Corporation. All rights
> + reserved.<BR>
>    (C) Copyright 2016-2017 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials
>    are licensed and made available under the terms and conditions of the BSD
> License @@ -1263,6 +1263,10 @@ TABLE_ITEM  SystemSlotTypeTable[] = {
>      L"PCI-X"
>    },
>    {
> +    0x13,
> +    L"AGP 8X"
> +  },
> +  {
>      0xA0,
>      L"PC-98/C20 "
>    },
> --
> 2.7.0.windows.1