public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Star Zeng <star.zeng@intel.com>
To: edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Jeff Fan <jeff.fan@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>, Liming Gao <liming.gao@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Subject: [PATCH 4/7] IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib
Date: Tue, 17 Jan 2017 15:08:37 +0800	[thread overview]
Message-ID: <1484636920-180432-5-git-send-email-star.zeng@intel.com> (raw)
In-Reply-To: <1484636920-180432-1-git-send-email-star.zeng@intel.com>

Use EfiEventEmptyFunction from UefiLib and remove the duplication
of event empty function.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298

Cc: Jeff Fan <jeff.fan@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c b/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c
index bf81de40a31d..8a64f041426a 100644
--- a/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c
+++ b/IntelFrameworkModulePkg/Universal/BdsDxe/BdsEntry.c
@@ -83,24 +83,6 @@ BdsInitialize (
   return Status;
 }
 
-
-/**
-  An empty function to pass error checking of CreateEventEx ().
-
-  @param  Event                 Event whose notification function is being invoked.
-  @param  Context               Pointer to the notification function's context,
-                                which is implementation-dependent.
-
-**/
-VOID
-EFIAPI
-BdsEmptyCallbackFunction (
-  IN EFI_EVENT                Event,
-  IN VOID                     *Context
-  )
-{
-}
-
 /**
 
   This function attempts to boot for the boot order specified
@@ -144,7 +126,7 @@ BdsBootDeviceSelect (
     Status = gBS->CreateEventEx (
                     EVT_NOTIFY_SIGNAL,
                     TPL_CALLBACK,
-                    BdsEmptyCallbackFunction,
+                    EfiEventEmptyFunction,
                     NULL,
                     &gConnectConInEventGuid,
                     &ConnectConInEvent
-- 
2.7.0.windows.1



  parent reply	other threads:[~2017-01-17  7:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17  7:08 [PATCH 0/7] Make the event empty function in UefiLib public Star Zeng
2017-01-17  7:08 ` [PATCH 1/7] MdePkg UefiLib: Make the event empty function public Star Zeng
2017-01-18  7:19   ` Gao, Liming
2017-01-17  7:08 ` [PATCH 2/7] IntelFrameworkPkg " Star Zeng
2017-01-20  4:42   ` Fan, Jeff
2017-01-17  7:08 ` [PATCH 3/7] MdeModulePkg: Use EfiEventEmptyFunction from UefiLib Star Zeng
2017-01-17  7:08 ` Star Zeng [this message]
2017-01-20  4:42   ` [PATCH 4/7] IntelFrameworkModulePkg: " Fan, Jeff
2017-01-17  7:08 ` [PATCH 5/7] CorebootPayloadPkg: Use EfiEventGroupSignal " Star Zeng
2017-01-20  4:12   ` Ma, Maurice
2017-01-17  7:08 ` [PATCH 6/7] QuarkPlatformPkg: " Star Zeng
2017-01-17  7:08 ` [PATCH 7/7] ArmPlatformPkg: " Star Zeng
2017-01-17  9:33   ` Ard Biesheuvel
2017-01-19 10:27 ` [PATCH 0/7] Make the event empty function in UefiLib public Zeng, Star
2017-01-19 10:30   ` Laszlo Ersek
2017-01-20  0:42     ` Tian, Feng
2017-01-20  8:04     ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484636920-180432-5-git-send-email-star.zeng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox