From: Thomas Huth <thuth@redhat.com>
To: edk2-devel@ml01.01.org
Cc: Laszlo Ersek <lersek@redhat.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: [PATCH] OvmfPkg: Remove superfluous return statements.
Date: Thu, 19 Jan 2017 10:17:37 +0100 [thread overview]
Message-ID: <1484817457-20169-1-git-send-email-thuth@redhat.com> (raw)
If the code eventually returns "Status" anyway, it does not make
sense to explicitely return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
OvmfPkg/Library/NvVarsFileLib/FsAccess.c | 3 ---
OvmfPkg/XenBusDxe/XenStore.c | 3 ---
2 files changed, 6 deletions(-)
diff --git a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
index 826901f..cd0bfff 100644
--- a/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
+++ b/OvmfPkg/Library/NvVarsFileLib/FsAccess.c
@@ -77,9 +77,6 @@ GetNvVarsFile (
),
0
);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c
index 1666c4b..76b6e29 100644
--- a/OvmfPkg/XenBusDxe/XenStore.c
+++ b/OvmfPkg/XenBusDxe/XenStore.c
@@ -1075,9 +1075,6 @@ XenStoreInit (
/* Initialize the shared memory rings to talk to xenstored */
Status = XenStoreInitComms (&xs);
- if (EFI_ERROR (Status)) {
- return Status;
- }
return Status;
}
--
1.8.3.1
next reply other threads:[~2017-01-19 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 9:17 Thomas Huth [this message]
2017-01-19 9:41 ` [PATCH] OvmfPkg: Remove superfluous return statements Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484817457-20169-1-git-send-email-thuth@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox