public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: edk2-devel@ml01.01.org
Cc: Siyuan Fu <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>
Subject: [PATCH] NetworkPkg: Remove superfluous return statement.
Date: Thu, 19 Jan 2017 10:37:31 +0100	[thread overview]
Message-ID: <1484818651-26205-1-git-send-email-thuth@redhat.com> (raw)

If the code eventually returns "Status" anyway, it does not make
sense to explicitely return "Status" in case of an error, too.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 NetworkPkg/HttpDxe/HttpsSupport.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/NetworkPkg/HttpDxe/HttpsSupport.c b/NetworkPkg/HttpDxe/HttpsSupport.c
index 77e5371..f0077dd 100644
--- a/NetworkPkg/HttpDxe/HttpsSupport.c
+++ b/NetworkPkg/HttpDxe/HttpsSupport.c
@@ -1294,10 +1294,6 @@ TlsCloseSession (
   FreePool (BufferOut);
   NetbufFree (PacketOut);
 
-  if (EFI_ERROR (Status)) {
-    return Status;
-  }
-
   return Status;
 }
 
-- 
1.8.3.1



             reply	other threads:[~2017-01-19  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  9:37 Thomas Huth [this message]
2017-01-20  0:39 ` [PATCH] NetworkPkg: Remove superfluous return statement Wu, Jiaxin
2017-01-23  2:35 ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484818651-26205-1-git-send-email-thuth@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox