Re: [edk2-staging] Create new edk2-test branch

[Andrew Fish <afish@apple.com>]

Mike,

Looks like something is eating it?

>cat TestCasePkg.patch 
diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
index 8a4bd7c..b72dfcb 100644
--- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
+++ b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
@@ -47,7 +47,7 @@ BBTestRegisterHandlerConsistencyTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -217,7 +217,7 @@ BBTestGetTimerPeriodConsistencyTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
diff --git a/TestCasePkg/Timer/ArchTimerBBTestFunction.c b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
index 46be5c7..dc76bec 100644
--- a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
+++ b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
@@ -47,7 +47,7 @@ BBTestRegisterHandlerInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -281,7 +281,7 @@ BBTestSetTimerPeriodInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -609,7 +609,7 @@ BBTestGetTimerPeriodInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (
@@ -749,7 +749,7 @@ BBTestGenerateSoftInterruptInterfaceTest (
   Status = gtBS->HandleProtocol (
                    SupportHandle,
                    &gEfiStandardTestLibraryGuid,
-                   &StandardLib
+                   (VOID **)&StandardLib
                    );
   if (EFI_ERROR(Status)) {
     StandardLib->RecordAssertion (


Thanks,

Andrew Fish

> On Jan 26, 2017, at 11:37 AM, Andrew Fish <afish@apple.com> wrote:
> 
>> 
>> On Jan 26, 2017, at 11:36 AM, Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>> wrote:
>> 
>> Andrew,
>> 
>> Was there supposed to be an attachment for the TestCasePkg fixes?
>> 
> 
> Yes.
> 
> 
> 
> Thanks,
> 
> Andrew FIsh
> 
>> Thanks,
>> 
>> Mike
>> 
>>> -----Original Message-----
>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org <mailto:edk2-devel-bounces@lists.01.org> <mailto:edk2-devel-bounces@lists.01.org <mailto:edk2-devel-bounces@lists.01.org>>] On Behalf Of Andrew
>>> Fish
>>> Sent: Thursday, January 26, 2017 10:26 AM
>>> To: Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>>
>>> Cc: edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>> (edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org> <mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>) <edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org><mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>>
>>> Subject: Re: [edk2] [edk2-staging] Create new edk2-test branch
>>> 
>>> 
>>>> On Jan 26, 2017, at 9:43 AM, Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>
>>> wrote:
>>>> 
>>>> Andrew,
>>>> 
>>>> Thanks for the patch for the additional compiler compatibility.  I will review
>>> and check in.
>>>> 
>>> 
>>> Mike,
>>> 
>>> Here is the TestCasePkg fixes.
>>> 
>>> 
>>>> I will also correct the Readme.md and add the Unix setup info.
>>>> 
>>> 
>>> Thanks.
>>> 
>>>> I am aware that the current post build step is a batch file.  We need to update
>>> that to be compatible with all supported development operating systems.
>>>> 
>>> 
>>> Is there a way to make the POSTBUILD step OS or Toolchain specific?
>>> 
>>> Thanks,
>>> 
>>> Andrew Fish
>>> 
>>> PS For both contributions....
>>> 
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Andrew Fish <afish@apple.com <mailto:afish@apple.com>>
>>> 
>>>> Mike
>>>> 
>>>> <>From: afish@apple.com <mailto:afish@apple.com> [mailto:afish@apple.com <mailto:afish@apple.com>]
>>>> Sent: Thursday, January 26, 2017 1:58 AM
>>>> To: Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>
>>>> Cc: edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> (edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>) <edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>
>>>> Subject: Re: [edk2] [edk2-staging] Create new edk2-test branch
>>>> 
>>>> 
>>>> On Jan 25, 2017, at 2:05 PM, Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>
>>> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>>> wrote:
>>>> 
>>>> The initial version of the edk2-test branch is checked in at:
>>>> 
>>>> https://github.com/tianocore/edk2-staging/tree/edk2-test <https://github.com/tianocore/edk2-staging/tree/edk2-test> <https://github.com/tianocore/edk2-staging/tree/edk2-test <https://github.com/tianocore/edk2-staging/tree/edk2-test>>
>>> <https://github.com/tianocore/edk2-staging/tree/edk2-test <https://github.com/tianocore/edk2-staging/tree/edk2-test> <https://github.com/tianocore/edk2-staging/tree/edk2-test <https://github.com/tianocore/edk2-staging/tree/edk2-test>>>
>>>> 
>>>> Mike,
>>>> 
>>>> I'm messing around with trying this on macOS.
>>>> 
>>>> git clone https://github.com/tianocore/edk2.git <https://github.com/tianocore/edk2.git> <https://github.com/tianocore/edk2.git <https://github.com/tianocore/edk2.git>>
>>> <https://github.com/tianocore/edk2.git <https://github.com/tianocore/edk2.git> <https://github.com/tianocore/edk2.git <https://github.com/tianocore/edk2.git>>>
>>>> git clone https://github.com/tianocore/edk2-staging.git <https://github.com/tianocore/edk2-staging.git> <https://github.com/tianocore/edk2-staging.git <https://github.com/tianocore/edk2-staging.git>>
>>> <https://github.com/tianocore/edk2-staging.git <https://github.com/tianocore/edk2-staging.git> <https://github.com/tianocore/edk2-staging.git <https://github.com/tianocore/edk2-staging.git>>> --brach edk2-test
>>>> 
>>>> set WORKSPACE=%CD%
>>>> set EDK_TOOLS_PATH=%WORKSPACE%\edk2\BaseTools
>>>> set PACKAGES_PATH=%WORKSPACE%\edk2;%WORKSPACE%\edk2-staging
>>>> set EDK_TOOLS_BIN=%WORKSPACE%\BaseTools\BinWrappers\WindowsLike
>>>> path=%path%;%WORKSPACE%\edk2\BaseTools\Bin\Win32
>>>> 
>>>> cd edk2
>>>> edkSetup.bat
>>>> 
>>>> build -a IA32 -a X64 -t VS2015x86 -p TestFrameworkPkg/TestFrameworkPkg.dsc
>>>> build -a IA32 -a X64 -t VS2015x86 -p TestCasePkg/TestCasePkg.dsc
>>>> At least with edksetup.sh this pattern fails as CONF_PATH is not set and it
>>> gets set in WORKSPACE. Maybe your terminal window was not clean when you tested?
>>>> 
>>>> Also is it correct that EDK_TOOLS_BIN is not in EDK_TOOLS_PATH?
>>>> 
>>>> On the Unix side this works for me:
>>>> 
>>>> export WORKSPACE=`pwd`
>>>> export EDK_TOOLS_PATH="$WORKSPACE/edk2/BaseTools"
>>>> export PACKAGES_PATH="$WORKSPACE/edk2:$WORKSPACE/edk2-staging"
>>>> export EDK_TOOLS_BIN="$$WORKSPACE/edk2/BaseTools/BinWrappers/PosixLike"
>>>> export CONF_PATH="$WORKSPACE/edk2/Conf"
>>>> export PATH="$PATH:$EDK_TOOLS_BIN"
>>>> 
>>>> Lots of minor change. Here is a patch for: >build -a IA32 -a X64 -t XCODE5  -p
>>> TestFrameworkPkg/TestFrameworkPkg.dsc
>>>> 
>>>> I get this far. This looks like a DOS batch file.
>>>> 
>>>> /bin/bash: /Users/andrewfish/work/src/TestFramework/edk2-
>>> staging/TestFrameworkPkg/GenFramework.cmd: Permission denied
>>>> 
>>>> 
>>>> Thanks,
>>>> 
>>>> Andrew Fish
>>>> 
>>>> 
>>>> 
>>>> Mike
>>>> 
>>>> 
>>>> -----Original Message-----
>>>> From: Kinney, Michael D
>>>> Sent: Tuesday, January 24, 2017 11:07 PM
>>>> To: edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>>> (edk2-
>>> devel@ml01.01.org <mailto:devel@ml01.01.org> <mailto:devel@ml01.01.org <mailto:devel@ml01.01.org>> <mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org> <mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>>) <edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org><mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>
>>> <mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org> <mailto:edk2-devel@ml01.01.org <mailto:edk2-devel@ml01.01.org>>>>;
>>>> Kinney, Michael D <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>
>>> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> <mailto:michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>>>
>>>> Subject: [edk2-staging] Create new edk2-test branch
>>>> 
>>>> I am creating a new branch in edk2-staging called edk2-test.
>>>> 
>>>> The purpose of this branch is to develop a test harness,
>>>> test case SDK, and library of test cases that can be used
>>>> as part of edk2 validation.
>>>> 
>>>> The initial version of this test harness is compatible with
>>>> binary releases of the PI SCTs and UEFI SCTs, are native
>>>> edk2 packages with no dependencies on the EdkCompatibilityPkg,
>>>> and the test harness runs using the latest version of the
>>>> UEFI Shell.
>>>> 
>>>> Additional work items:
>>>> * Update to take advantage of latest edk2 features/libraries.
>>>> * Update for all supported CPU types
>>>> * Update for all supported compilers
>>>> * Review initial test harness features and determine
>>>> what features should be dropped and what new features
>>>> should be added.
>>>> * Determine where the test harness, test case SDK, and
>>>> test cases should live once the initial functional and
>>>> quality criteria are met.  Could be packages in the
>>>> edk2 repo or packages in a new edk2-test repo.  Other
>>>> options???
>>>> * Resolve compatibility issues with binary releases of the
>>>> PI SCTs and UEFI SCTs.
>>>> * Update test harness to support PEI tests
>>>> * Update test harness to support Runtime tests
>>>> * Update test harness to support SMM tests
>>>> * Optimize performance of the test harness and tests.
>>>> 
>>>> Please contact me if you are interested in helping with the
>>>> test harness, the test case SDK, or the development of
>>>> test cases.
>>>> 
>>>> Thanks,
>>>> 
>>>> Mike
>>>> 
>>>> _______________________________________________
>>>> edk2-devel mailing list
>>>> edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org> <mailto:edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>>>
>>>> https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel> <https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>>
>>> <https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel> <https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>>>
>>> _______________________________________________
>>> edk2-devel mailing list
>>> edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
>>> https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel