From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD64081EE6 for ; Mon, 23 Jan 2017 23:51:01 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 23 Jan 2017 23:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,277,1477983600"; d="scan'208";a="216900792" Received: from shwdeopenpsi014.ccr.corp.intel.com ([10.239.9.13]) by fmsmga004.fm.intel.com with ESMTP; 23 Jan 2017 23:51:00 -0800 From: Hao Wu To: edk2-devel@lists.01.org Cc: Hao Wu Date: Tue, 24 Jan 2017 15:50:57 +0800 Message-Id: <1485244258-12316-1-git-send-email-hao.a.wu@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.0 Subject: [PATCH 0/6] Refine type cast for pointer subtraction X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2017 07:51:01 -0000 Please note that this patch is maily for feedback collection and the only the MdeModulePkg part of the series is sent out firstly. For pointer subtraction, the result is of type "ptrdiff_t". According to the C11 spec, ptrdiff_t is a signed integer type but its size is implementation-defined. There are cases that the result of pointer subtraction is type casted to UINTN, like: UINT8 *Ptr1, *Ptr2; UINTN PtrDiff; ... PtrDiff = (UINTN) (Ptr1 - Ptr2); Some static code checkers may warn that the pointer subtraction might overflow first and then the result is being cast to a bigger size. The series will cast each pointer to UINTN first and then perform the subtraction: PtrDiff = (UINTN) Ptr1 - (UINTN) Ptr2; Hao Wu (6): MdeModulePkg: Refine type cast for pointer subtraction CryptoPkg: Refine type cast for pointer subtraction IntelFrameworkModulePkg: Refine type cast for pointer subtraction NetworkPkg: Refine type cast for pointer subtraction SecurityPkg: Refine type cast for pointer subtraction ShellPkg: Refine type cast for pointer subtraction .../BaseCryptLib/SysCall/RuntimeMemAllocation.c | 6 +++--- IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyPci.c | 4 ++-- .../Library/GenericBdsLib/BdsBoot.c | 4 ++-- .../Library/GenericBdsLib/BdsConsole.c | 4 ++-- .../Library/GenericBdsLib/BdsMisc.c | 4 ++-- .../Library/LegacyBootManagerLib/LegacyBm.c | 4 ++-- .../Universal/BdsDxe/BootMaint/BootOption.c | 6 +++--- MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- MdeModulePkg/Include/Library/NetLib.h | 6 +++--- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++-- .../Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +- MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 6 +++--- .../Library/PiDxeS3BootScriptLib/BootScriptSave.c | 4 ++-- MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c | 4 ++-- MdeModulePkg/Universal/DebugPortDxe/DebugPort.c | 4 ++-- .../FaultTolerantWriteDxe/FaultTolerantWrite.c | 4 ++-- MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 4 ++-- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 10 +++++----- NetworkPkg/HttpDxe/HttpImpl.c | 6 +++--- .../DxeImageVerificationLib/DxeImageVerificationLib.c | 18 +++++++++--------- .../DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 10 +++++----- SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 6 +++--- SecurityPkg/Tcg/Tcg2Dxe/MeasureBootPeCoff.c | 10 +++++----- SecurityPkg/Tcg/TrEEDxe/MeasureBootPeCoff.c | 10 +++++----- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 14 +++++++------- ShellPkg/Application/Shell/ShellParametersProtocol.c | 6 +++--- ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 4 ++-- .../UefiShellDebug1CommandsLib/SmbiosView/SmbiosView.c | 4 ++-- ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 4 ++-- ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c | 6 +++--- 30 files changed, 91 insertions(+), 91 deletions(-) -- 1.9.5.msysgit.0