public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: edk2-devel@ml01.01.org
Cc: Chao Zhang <chao.b.zhang@intel.com>
Subject: [PATCH] SecurityPkg: Remove superfluous return statement
Date: Wed, 25 Jan 2017 10:58:55 +0100	[thread overview]
Message-ID: <1485338335-29716-1-git-send-email-thuth@redhat.com> (raw)

If the code eventually returns "Status" anyway, it does not make
sense to explicitly return "Status" in case of an error, too.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
index 33f77bd..a95ea2f 100644
--- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
+++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
@@ -1286,10 +1286,6 @@ AhciModeInitialize (
              EFI_TIMER_PERIOD_SECONDS(16)
              );
 
-  if (EFI_ERROR (Status)) {
-    return Status;
-  }
-
   return Status;
 }
 
-- 
1.8.3.1



             reply	other threads:[~2017-01-25  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25  9:58 Thomas Huth [this message]
     [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D630C@shsmsx102.ccr.corp.intel.com>
2017-02-03  5:23   ` [PATCH] SecurityPkg: Remove superfluous return statement Zhang, Chao B
2017-02-16  9:44 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485338335-29716-1-git-send-email-thuth@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox