public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Kinney <michael.d.kinney@intel.com>
To: edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>,
	Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Subject: [staging/edk2-test PATCH 3/6] TestFrameworkPkg: Fix VS2015 compatibility issues
Date: Tue, 31 Jan 2017 10:45:19 -0800	[thread overview]
Message-ID: <1485888322-56072-4-git-send-email-michael.d.kinney@intel.com> (raw)
In-Reply-To: <1485888322-56072-1-git-send-email-michael.d.kinney@intel.com>

Cc: Andrew Fish <afish@apple.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
---
 TestFrameworkPkg/Sct/Execute/ExecuteSupport.c | 17 -----------------
 TestFrameworkPkg/Sct/UI/KeyFunction.c         | 14 +++++++-------
 2 files changed, 7 insertions(+), 24 deletions(-)

diff --git a/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c b/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
index 43b117d..8036050 100644
--- a/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
+++ b/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
@@ -647,23 +647,6 @@ DeviceConfigGetString (
 }
 
 
-EFI_STATUS
-DeviceConfigSetString (
-  IN EFI_INI_FILE_HANDLE    IniFile,
-  IN UINT32                 Order,
-  IN CHAR16                 *Key,
-  IN CHAR16                 *Buffer
-  )
-{
-  return IniFile->SetStringByOrder (
-                    IniFile,
-                    Order,
-                    EFI_SCT_SECTION_DEVICE_CONFIG,
-                    Key,
-                    Buffer
-                    );
-}
-
 STATIC
 VOID
 InsertChildHandles (
diff --git a/TestFrameworkPkg/Sct/UI/KeyFunction.c b/TestFrameworkPkg/Sct/UI/KeyFunction.c
index 30e1e8a..34e683f 100644
--- a/TestFrameworkPkg/Sct/UI/KeyFunction.c
+++ b/TestFrameworkPkg/Sct/UI/KeyFunction.c
@@ -637,11 +637,11 @@ Returns:
   BOOLEAN                 WAITING;
   CHAR16                  Buffer[EFI_MAX_EDIT_LENGTH + 1];
   CHAR16                  TempStr[EFI_MAX_ITEM_VALUE_LENGTH + 1];
-  INTN                    XOffSetInScreen;
-  INTN                    XOffSetInBuffer;
-  INTN                    FirstInDisplay;
-  INTN                    LastInDisplay;
-  INTN                    CurrentLength;
+  UINTN                   XOffSetInScreen;
+  UINTN                   XOffSetInBuffer;
+  UINTN                   FirstInDisplay;
+  UINTN                   LastInDisplay;
+  UINTN                   CurrentLength;
   UINTN                   TempValue;
   EFI_DIALOG_CONTEXT      MsgDialogContext;
   CHAR16                  *MsgDialogTitle;
@@ -2187,8 +2187,8 @@ Returns:
   BOOLEAN         BufferChanged;
   CHAR16          Buffer[EFI_MAX_ITER_EDIT_LENGTH + 1];
   CHAR16          TempStr[EFI_MAX_ITER_EDIT_LENGTH + 1];
-  INTN            XOffSetInBuffer;
-  INTN            CurrentLength;
+  UINTN           XOffSetInBuffer;
+  UINTN           CurrentLength;
   UINT32          TempValue;
 
   //
-- 
2.6.3.windows.1



  parent reply	other threads:[~2017-01-31 18:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 18:45 [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 1/6] edk2-test: Update Readme.md Michael Kinney
2017-01-31 19:29   ` Michael Zimmermann
2017-01-31 22:41     ` Supreeth Venkatesh
2017-01-31 23:02       ` Andrew Fish
2017-01-31 23:08         ` Supreeth Venkatesh
2017-01-31 23:32       ` Kinney, Michael D
2017-01-31 23:42         ` Supreeth Venkatesh
2017-02-01  2:01     ` Kinney, Michael D
2017-02-03  6:39   ` Gao, Liming
2017-01-31 18:45 ` [staging/edk2-test PATCH 2/6] TestFrameworkPkg: Fix XCODE compatibility issues Michael Kinney
2017-01-31 18:45 ` Michael Kinney [this message]
2017-01-31 18:45 ` [staging/edk2-test PATCH 4/6] TestFrameworkPkg: Fix GCC " Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 5/6] TestCasePkg: Fix XCODE " Michael Kinney
2017-01-31 18:45 ` [staging/edk2-test PATCH 6/6] TestCasePkg: Fix GCC " Michael Kinney
2017-02-01 22:08 ` [staging/edk2-test PATCH 0/6] Fix XCODE and GCC build issues Andrew Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485888322-56072-4-git-send-email-michael.d.kinney@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox