* [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
@ 2017-02-01 3:35 Thomas Palmer
2017-02-03 8:06 ` Ni, Ruiyu
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Palmer @ 2017-02-01 3:35 UTC (permalink / raw)
To: edk2-devel; +Cc: ruiyu.ni, Thomas Palmer
On GCC built UEFIs, the "cp" command fails with "The source and
destination are the same".
The root cause is that StrniCmp failed to detect a case-
insensitive string difference due to the InternalCharToUpper function
being improperly declared.
Fix is to add missing EFIAPI token to match the original
implementation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
---
.../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
index 7948e53cfc46..4dbff4de26f8 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
@@ -21,6 +21,7 @@
* functions are non-interactive only
+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
@@ -268,6 +269,7 @@ VerifyIntermediateDirectories (
@return Char as an upper case character.
**/
CHAR16
+EFIAPI
InternalCharToUpper (
IN CONST CHAR16 Char
);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
2017-02-01 3:35 [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems Thomas Palmer
@ 2017-02-03 8:06 ` Ni, Ruiyu
2017-02-03 17:45 ` Carsey, Jaben
0 siblings, 1 reply; 3+ messages in thread
From: Ni, Ruiyu @ 2017-02-03 8:06 UTC (permalink / raw)
To: Thomas Palmer, edk2-devel@lists.01.org
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Regards,
Ray
>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Palmer
>Sent: Wednesday, February 1, 2017 11:35 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
>Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
>
>On GCC built UEFIs, the "cp" command fails with "The source and
>destination are the same".
>
>The root cause is that StrniCmp failed to detect a case-
>insensitive string difference due to the InternalCharToUpper function
>being improperly declared.
>
>Fix is to add missing EFIAPI token to match the original
>implementation.
>
>Contributed-under: TianoCore Contribution Agreement 1.0
>Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
>---
> .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>index 7948e53cfc46..4dbff4de26f8 100644
>--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c
>@@ -21,6 +21,7 @@
>
> * functions are non-interactive only
>
>+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> This program and the accompanying materials
>@@ -268,6 +269,7 @@ VerifyIntermediateDirectories (
> @return Char as an upper case character.
> **/
> CHAR16
>+EFIAPI
> InternalCharToUpper (
> IN CONST CHAR16 Char
> );
>--
>2.7.4
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems
2017-02-03 8:06 ` Ni, Ruiyu
@ 2017-02-03 17:45 ` Carsey, Jaben
0 siblings, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2017-02-03 17:45 UTC (permalink / raw)
To: Ni, Ruiyu, Thomas Palmer, edk2-devel@lists.01.org; +Cc: Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Friday, February 3, 2017 12:06 AM
> To: Thomas Palmer <thomas.palmer@hpe.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp"
> for GCC systems
> Importance: High
>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
> Regards,
> Ray
>
> >-----Original Message-----
> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> >Thomas Palmer
> >Sent: Wednesday, February 1, 2017 11:35 AM
> >To: edk2-devel@lists.01.org
> >Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> >Subject: [edk2] [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix
> >"cp" for GCC systems
> >
> >On GCC built UEFIs, the "cp" command fails with "The source and
> >destination are the same".
> >
> >The root cause is that StrniCmp failed to detect a case- insensitive
> >string difference due to the InternalCharToUpper function being
> >improperly declared.
> >
> >Fix is to add missing EFIAPI token to match the original
> >implementation.
> >
> >Contributed-under: TianoCore Contribution Agreement 1.0
> >Signed-off-by: Thomas Palmer <thomas.palmer@hpe.com>
> >---
> > .../Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c | 2
> ++
> > 1 file changed, 2 insertions(+)
> >
> >diff --git
> >a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi
> >b.c
> >b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi
> >b.c index 7948e53cfc46..4dbff4de26f8 100644
> >---
> >a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi
> >b.c
> >+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comman
> >+++ dsLib.c
> >@@ -21,6 +21,7 @@
> >
> > * functions are non-interactive only
> >
> >+ (C) Copyright 2017 Hewlett Packard Enterprise Development LP<BR>
> > Copyright (c) 2014 Hewlett-Packard Development Company, L.P.
> > Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
> > This program and the accompanying materials @@ -268,6 +269,7 @@
> >VerifyIntermediateDirectories (
> > @return Char as an upper case character.
> > **/
> > CHAR16
> >+EFIAPI
> > InternalCharToUpper (
> > IN CONST CHAR16 Char
> > );
> >--
> >2.7.4
> >
> >_______________________________________________
> >edk2-devel mailing list
> >edk2-devel@lists.01.org
> >https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-03 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 3:35 [PATCH 1/1] ShellPkg/UefiShellLevel2CommandsLib: Fix "cp" for GCC systems Thomas Palmer
2017-02-03 8:06 ` Ni, Ruiyu
2017-02-03 17:45 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox