From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <supreeth.venkatesh@arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id A702481FBD
 for <edk2-devel@lists.01.org>; Wed,  1 Feb 2017 09:48:34 -0800 (PST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8BBBBAD7;
 Wed,  1 Feb 2017 09:48:34 -0800 (PST)
Received: from [192.168.150.241] (u201365.usa.arm.com [10.118.28.87])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 53EE23F24D;
 Wed,  1 Feb 2017 09:48:34 -0800 (PST)
Message-ID: <1485971313.3126.1.camel@arm.com>
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>
Date: Wed, 01 Feb 2017 11:48:33 -0600
In-Reply-To: <1485942552-47388-4-git-send-email-michael.d.kinney@intel.com>
References: <1485942552-47388-1-git-send-email-michael.d.kinney@intel.com>
 <1485942552-47388-4-git-send-email-michael.d.kinney@intel.com>
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Subject: Re: [staging/edk2-test PATCH V2 3/6] TestFrameworkPkg: Fix VS2015 compatibility issues
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2017 17:48:34 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On Wed, 2017-02-01 at 01:49 -0800, Michael Kinney wrote:
> Cc: Andrew Fish <afish@apple.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
This looks fine to me.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> ---
>  TestFrameworkPkg/Sct/Execute/ExecuteSupport.c | 17 -----------------
>  TestFrameworkPkg/Sct/UI/KeyFunction.c         | 14 +++++++-------
>  2 files changed, 7 insertions(+), 24 deletions(-)
> 
> diff --git a/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
> b/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
> index 43b117d..8036050 100644
> --- a/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
> +++ b/TestFrameworkPkg/Sct/Execute/ExecuteSupport.c
> @@ -647,23 +647,6 @@ DeviceConfigGetString (
>  }
>  
>  
> -EFI_STATUS
> -DeviceConfigSetString (
> -  IN EFI_INI_FILE_HANDLE    IniFile,
> -  IN UINT32                 Order,
> -  IN CHAR16                 *Key,
> -  IN CHAR16                 *Buffer
> -  )
> -{
> -  return IniFile->SetStringByOrder (
> -                    IniFile,
> -                    Order,
> -                    EFI_SCT_SECTION_DEVICE_CONFIG,
> -                    Key,
> -                    Buffer
> -                    );
> -}
> -
>  STATIC
>  VOID
>  InsertChildHandles (
> diff --git a/TestFrameworkPkg/Sct/UI/KeyFunction.c
> b/TestFrameworkPkg/Sct/UI/KeyFunction.c
> index 30e1e8a..34e683f 100644
> --- a/TestFrameworkPkg/Sct/UI/KeyFunction.c
> +++ b/TestFrameworkPkg/Sct/UI/KeyFunction.c
> @@ -637,11 +637,11 @@ Returns:
>    BOOLEAN                 WAITING;
>    CHAR16                  Buffer[EFI_MAX_EDIT_LENGTH + 1];
>    CHAR16                  TempStr[EFI_MAX_ITEM_VALUE_LENGTH + 1];
> -  INTN                    XOffSetInScreen;
> -  INTN                    XOffSetInBuffer;
> -  INTN                    FirstInDisplay;
> -  INTN                    LastInDisplay;
> -  INTN                    CurrentLength;
> +  UINTN                   XOffSetInScreen;
> +  UINTN                   XOffSetInBuffer;
> +  UINTN                   FirstInDisplay;
> +  UINTN                   LastInDisplay;
> +  UINTN                   CurrentLength;
>    UINTN                   TempValue;
>    EFI_DIALOG_CONTEXT      MsgDialogContext;
>    CHAR16                  *MsgDialogTitle;
> @@ -2187,8 +2187,8 @@ Returns:
>    BOOLEAN         BufferChanged;
>    CHAR16          Buffer[EFI_MAX_ITER_EDIT_LENGTH + 1];
>    CHAR16          TempStr[EFI_MAX_ITER_EDIT_LENGTH + 1];
> -  INTN            XOffSetInBuffer;
> -  INTN            CurrentLength;
> +  UINTN           XOffSetInBuffer;
> +  UINTN           CurrentLength;
>    UINT32          TempValue;
>  
>    //