public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>
Subject: Re: [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE compatibility issues
Date: Wed, 01 Feb 2017 13:16:55 -0600	[thread overview]
Message-ID: <1485976615.3126.2.camel@arm.com> (raw)
In-Reply-To: <1485942552-47388-6-git-send-email-michael.d.kinney@intel.com>

On Wed, 2017-02-01 at 01:49 -0800, Michael Kinney wrote:
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Andrew Fish <afish@apple.com>
This looks fine to me.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

> ---
>  TestCasePkg/Timer/ArchTimerBBTestConformance.c | 5 ++---
>  TestCasePkg/Timer/ArchTimerBBTestFunction.c    | 8 ++++----
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> index 8a4bd7c..58c4ade 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -217,7 +217,7 @@ BBTestGetTimerPeriodConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -262,4 +262,3 @@ BBTestGetTimerPeriodConsistencyTest (
>  
>    return EFI_SUCCESS;
>  }
> -
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> index 46be5c7..dc76bec 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -281,7 +281,7 @@ BBTestSetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -609,7 +609,7 @@ BBTestGetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -749,7 +749,7 @@ BBTestGenerateSoftInterruptInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (


  reply	other threads:[~2017-02-01 19:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01  9:49 [staging/edk2-test PATCH V2 0/6] Fix XCODE and GCC build issues Michael Kinney
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 1/6] edk2-test: Update Readme.md Michael Kinney
2017-02-01 17:35   ` Supreeth Venkatesh
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 2/6] TestFrameworkPkg: Fix XCODE compatibility issues Michael Kinney
2017-02-01 17:46   ` Supreeth Venkatesh
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 3/6] TestFrameworkPkg: Fix VS2015 " Michael Kinney
2017-02-01 17:48   ` Supreeth Venkatesh
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 4/6] TestFrameworkPkg: Fix GCC " Michael Kinney
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE " Michael Kinney
2017-02-01 19:16   ` Supreeth Venkatesh [this message]
2017-02-01  9:49 ` [staging/edk2-test PATCH V2 6/6] TestCasePkg: Fix GCC " Michael Kinney
2017-02-01 19:17   ` Supreeth Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485976615.3126.2.camel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox