From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <supreeth.venkatesh@arm.com>
Received: from foss.arm.com (foss.arm.com [217.140.101.70])
 by ml01.01.org (Postfix) with ESMTP id 6176881FC7
 for <edk2-devel@lists.01.org>; Wed,  1 Feb 2017 11:16:56 -0800 (PST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07714C14;
 Wed,  1 Feb 2017 11:16:56 -0800 (PST)
Received: from [192.168.150.241] (u201365.usa.arm.com [10.118.28.87])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C15E83F220;
 Wed,  1 Feb 2017 11:16:55 -0800 (PST)
Message-ID: <1485976615.3126.2.camel@arm.com>
From: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Andrew Fish <afish@apple.com>
Date: Wed, 01 Feb 2017 13:16:55 -0600
In-Reply-To: <1485942552-47388-6-git-send-email-michael.d.kinney@intel.com>
References: <1485942552-47388-1-git-send-email-michael.d.kinney@intel.com>
 <1485942552-47388-6-git-send-email-michael.d.kinney@intel.com>
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Subject: Re: [staging/edk2-test PATCH V2 5/6] TestCasePkg: Fix XCODE compatibility issues
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2017 19:16:56 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On Wed, 2017-02-01 at 01:49 -0800, Michael Kinney wrote:
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Andrew Fish <afish@apple.com>
This looks fine to me.

Reviewed-by: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

> ---
>  TestCasePkg/Timer/ArchTimerBBTestConformance.c | 5 ++---
>  TestCasePkg/Timer/ArchTimerBBTestFunction.c    | 8 ++++----
>  2 files changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> index 8a4bd7c..58c4ade 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestConformance.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -217,7 +217,7 @@ BBTestGetTimerPeriodConsistencyTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -262,4 +262,3 @@ BBTestGetTimerPeriodConsistencyTest (
>  
>    return EFI_SUCCESS;
>  }
> -
> diff --git a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> index 46be5c7..dc76bec 100644
> --- a/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> +++ b/TestCasePkg/Timer/ArchTimerBBTestFunction.c
> @@ -47,7 +47,7 @@ BBTestRegisterHandlerInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -281,7 +281,7 @@ BBTestSetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -609,7 +609,7 @@ BBTestGetTimerPeriodInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (
> @@ -749,7 +749,7 @@ BBTestGenerateSoftInterruptInterfaceTest (
>    Status = gtBS->HandleProtocol (
>                     SupportHandle,
>                     &gEfiStandardTestLibraryGuid,
> -                   &StandardLib
> +                   (VOID **)&StandardLib
>                     );
>    if (EFI_ERROR(Status)) {
>      StandardLib->RecordAssertion (