From: Jiewen Yao <jiewen.yao@intel.com>
To: edk2-devel@lists.01.org
Cc: Wang Cloud <winggundum82@163.com>
Subject: [PATCH] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix logic error.
Date: Mon, 6 Feb 2017 22:33:45 -0800 [thread overview]
Message-ID: <1486449225-16556-1-git-send-email-jiewen.yao@intel.com> (raw)
This patch fixes https://bugzilla.tianocore.org/show_bug.cgi?id=367
Cc: Wang Cloud <winggundum82@163.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c
index dfd8d10..62be8eb 100644
--- a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c
+++ b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c
@@ -643,7 +643,7 @@ CapsuleAuthenticateSystemFirmware (
return EFI_SECURITY_VIOLATION;
}
} else {
- if (CurrentImageFmpInfo->Version < ImageFmpInfo->LowestSupportedImageVersion) {
+ if (ImageFmpInfo->Version < CurrentImageFmpInfo->LowestSupportedImageVersion) {
*LastAttemptStatus = LAST_ATTEMPT_STATUS_ERROR_INCORRECT_VERSION;
DEBUG((DEBUG_INFO, "LowestSupportedImageVersion check - fail\n"));
return EFI_SECURITY_VIOLATION;
--
2.7.4.windows.1
next reply other threads:[~2017-02-07 6:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 6:33 Jiewen Yao [this message]
2017-02-07 8:58 ` [PATCH] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix logic error wang xiaofeng
2017-02-10 9:27 ` CapsuleApp behavior for CAPSULE_FLAGS_PERSIST_ACROSS_RESET only capsule wang xiaofeng
2017-02-10 11:24 ` Yao, Jiewen
2017-02-13 2:09 ` wang xiaofeng
2017-02-13 3:52 ` Yao, Jiewen
2017-02-13 4:46 ` wang xiaofeng
2017-02-17 1:23 ` Yao, Jiewen
2017-02-17 1:38 ` wang xiaofeng
2017-02-20 1:27 ` wang xiaofeng
2017-02-23 11:21 ` Tcg2Pei.efi assert after sync to latest trunk wang xiaofeng
2017-02-23 13:01 ` Gao, Liming
2017-02-24 5:08 ` wang xiaofeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486449225-16556-1-git-send-email-jiewen.yao@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox