From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C5F48225F for ; Tue, 21 Feb 2017 17:58:07 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2017 17:58:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,191,1484035200"; d="scan'208";a="936658451" Received: from ahirst-mobl.amr.corp.intel.com (HELO localhost) ([10.252.140.121]) by orsmga003.jf.intel.com with ESMTP; 21 Feb 2017 17:58:06 -0800 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel-01 Message-ID: <148772868625.12591.11299125496281974778@jljusten-ivb> From: Jordan Justen In-Reply-To: <20170221153812.1420-1-lersek@redhat.com> References: <20170221153812.1420-1-lersek@redhat.com> User-Agent: alot/0.5.1 Date: Tue, 21 Feb 2017 17:58:06 -0800 Subject: Re: [PATCH 0/6] OvmfPkg: AcpiPlatformDxe, QemuFwCfg: small cleanups after WRITE_POINTER X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 01:58:07 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Good cleanups. Thanks for taking the extra time sort these out! Reviewed-by: Jordan Justen Unfortunately, https://bugzilla.tianocore.org/show_bug.cgi?id=3D394 may not be quite so 'fun'. :) -Jordan On 2017-02-21 07:38:06, Laszlo Ersek wrote: > Most of these were suggested by Jordan. > = > Cc: Jordan Justen > = > Repo: https://github.com/lersek/edk2.git > Branch: write_pointer_followup > = > Thanks! > Laszlo > = > Laszlo Ersek (6): > OvmfPkg/AcpiPlatformDxe: drop double right shift in ADD/WRITE POINTER > cmds > OvmfPkg/AcpiPlatformDxe: update PointerValue comments in > "BootScript.c" > OvmfPkg/QemuFwCfgLib: move types/macros from lib class to > IndustryStandard > OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_SELECTOR, adapt the package > OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DATA, adapt the package > OvmfPkg/QemuFwCfg: introduce FW_CFG_IO_DMA_ADDRESS, adapt the package > = > OvmfPkg/Include/IndustryStandard/QemuFwCfg.h | 104 ++++++++++++++++++++ > OvmfPkg/Include/Library/QemuFwCfgLib.h | 70 +------------ > OvmfPkg/AcpiPlatformDxe/BootScript.c | 18 ++-- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 12 +-- > OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 6 +- > 6 files changed, 128 insertions(+), 90 deletions(-) > create mode 100644 OvmfPkg/Include/IndustryStandard/QemuFwCfg.h > = > -- = > 2.9.3 >=20