From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDFBA81EA5 for ; Tue, 28 Feb 2017 00:17:34 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 28 Feb 2017 00:17:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,218,1484035200"; d="scan'208";a="938880550" Received: from shwdeopenpsi114.ccr.corp.intel.com ([10.239.157.135]) by orsmga003.jf.intel.com with ESMTP; 28 Feb 2017 00:17:33 -0800 From: Dandan Bi To: edk2-devel@lists.01.org Cc: Jiewen Yao Date: Tue, 28 Feb 2017 16:17:20 +0800 Message-Id: <1488269840-32256-1-git-send-email-dandan.bi@intel.com> X-Mailer: git-send-email 1.9.5.msysgit.1 Subject: [patch] MdeModulePkg: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:17:34 -0000 1. Make function comments align with the function. 2. Change the FILE_GUID value in SmmSmiHandlerProfileLib.inf since it is duplicated with the FILE_GUID value in SmiHandlerProfileLibNull.inf 3. Add missing PCD PROMPT&HELP string to uni file. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 2 +- .../SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf | 2 +- MdeModulePkg/MdeModulePkg.uni | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c index 00cab0c..84a1c8e 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -243,11 +243,11 @@ GetShortPdbFileName ( The following methods will be tried orderly: 1. Image PDB 2. FFS UI section 3. Image GUID - @param[in] DriverInfo Pointer to memory profile driver info. + @param[in] ImageStruct Point to the image structure. @return The resulting Ascii name string is stored in the mNameString global array. **/ CHAR8 * diff --git a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf index 0c1ad7e..ba0d65e 100644 --- a/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf +++ b/MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf @@ -17,11 +17,11 @@ [Defines] INF_VERSION = 0x00010005 BASE_NAME = SmmSmiHandlerProfileLib MODULE_UNI_FILE = SmmSmiHandlerProfileLib.uni - FILE_GUID = B43D1B52-6251-4E6F-82EC-A599A5EE94C1 + FILE_GUID = FC38CEAE-FB74-4049-A51C-68F0BA69DA7D MODULE_TYPE = DXE_SMM_DRIVER VERSION_STRING = 1.0 LIBRARY_CLASS = SmiHandlerProfileLib|DXE_SMM_DRIVER CONSTRUCTOR = SmmSmiHandlerProfileLibConstructor diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 5436b60..ff0d697 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1073,5 +1073,19 @@ #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT #language en-US "If there is any test key used by the platform." #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP #language en-US "This dynamic PCD holds the information if there is any test key used by the platform." +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_PROMPT #language en-US "SmiHandlerProfile Property." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSmiHandlerProfilePropertyMask_HELP #language en-US "The mask is used to control SmiHandlerProfile behavior.

\n" + "BIT0 - Enable SmiHandlerProfile.
" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_PROMPT #language en-US "Set image protection policy." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdImageProtectionPolicy_HELP #language en-US "Set image protection policy. The policy is bitwise.\n" + "If a bit is set, the image will be protected by DxeCore if it is aligned.\n" + "The code section becomes read-only, and the data section becomes non-executable.\n" + "If a bit is clear, the image will not be protected.

\n" + "BIT0 - Image from unknown device.
\n" + "BIT1 - Image from firmware volume.
" + -- 1.9.5.msysgit.1