[PATCH 0/2] DP: Link DxeSmmPerformanceLib to make DP command generic

[PATCH 0/2] DP: Link DxeSmmPerformanceLib to make DP command generic

[Star Zeng]

Current PerformancePkg is linking DxePerformanceLib
that could only dump PEI and DXE performance log.
Current ShellPkg is linking BasePerformanceLibNull.

We could link DxeSmmPerformanceLib to make DP command
built from PerformancePkg and ShellPkg generic.

Star Zeng (2):
  PerformancePkg: Link DxeSmmPerformanceLib to make DP command generic
  ShellPkg: Link DxeSmmPerformanceLib to make DP command generic

 PerformancePkg/PerformancePkg.dsc | 21 ++-------------------
 ShellPkg/ShellPkg.dsc             |  2 +-
 2 files changed, 3 insertions(+), 20 deletions(-)

-- 
2.8.1.windows.1

[PATCH 1/2] PerformancePkg: Link DxeSmmPerformanceLib to make DP command generic

[Star Zeng]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=412

Also remove the unreferenced TimerLib mapping.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 PerformancePkg/PerformancePkg.dsc | 21 ++-------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/PerformancePkg/PerformancePkg.dsc b/PerformancePkg/PerformancePkg.dsc
index 4278cbd09271..95cc905cbb66 100644
--- a/PerformancePkg/PerformancePkg.dsc
+++ b/PerformancePkg/PerformancePkg.dsc
@@ -1,7 +1,7 @@
 ## @file
 # Build description file to generate Shell DP application.
 #
-# Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
@@ -45,7 +45,7 @@ [LibraryClasses]
   PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
-  PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
+  PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerformanceLib.inf
   IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
   SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
@@ -56,23 +56,6 @@ [LibraryClasses]
   PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
   DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
 
-[LibraryClasses.IA32, LibraryClasses.X64]
-  # This library instance mapping needs adjusting based on platform.
-  # The TimerLib instance must match the TimerLib the platform was built with.
-  # If the platform was built with more than one TimerLib type, then this utility
-  # will produce invalid results for any measurements done with a TimerLib instance
-  # that is different than the one below.
-  #
-  # TimerLib|MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf
-  TimerLib|PerformancePkg/Library/TscTimerLib/DxeTscTimerLib.inf
-
-[LibraryClasses.IPF]
-  PalLib|MdePkg/Library/UefiPalLib/UefiPalLib.inf
-  TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
-
-[LibraryClasses.EBC]
-  TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf
-
 [Components.IA32, Components.X64]
   PerformancePkg/Library/TscTimerLib/DxeTscTimerLib.inf
   PerformancePkg/Library/TscTimerLib/PeiTscTimerLib.inf
-- 
2.8.1.windows.1

[PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP command generic

[Star Zeng]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=412

Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 ShellPkg/ShellPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
index a87428ad6f76..4126e846cf71 100644
--- a/ShellPkg/ShellPkg.dsc
+++ b/ShellPkg/ShellPkg.dsc
@@ -107,7 +107,7 @@ [Components]
 
   ShellPkg/Library/UefiDpLib/UefiDpLib.inf {
     <LibraryClasses>
-      PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanceLibNull.inf
+      PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmmPerformanceLib.inf
       DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
   }
 
-- 
2.8.1.windows.1

Re: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP command generic

[Ni, Ruiyu]

It's great we finally have a platform independent PerformanceLib.
Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>

Thanks/Ray

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, March 1, 2017 3:53 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP
> command generic
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=412
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  ShellPkg/ShellPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index
> a87428ad6f76..4126e846cf71 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -107,7 +107,7 @@ [Components]
> 
>    ShellPkg/Library/UefiDpLib/UefiDpLib.inf {
>      <LibraryClasses>
> -
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanc
> eLibNull.inf
> +
> +
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> Perform
> + anceLib.inf
>        DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>    }
> 
> --
> 2.8.1.windows.1

Re: [PATCH 0/2] DP: Link DxeSmmPerformanceLib to make DP command generic

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star
>Zeng
>Sent: Wednesday, March 01, 2017 3:53 PM
>To: edk2-devel@lists.01.org
>Cc: Zeng, Star <star.zeng@intel.com>
>Subject: [edk2] [PATCH 0/2] DP: Link DxeSmmPerformanceLib to make DP
>command generic
>
>Current PerformancePkg is linking DxePerformanceLib
>that could only dump PEI and DXE performance log.
>Current ShellPkg is linking BasePerformanceLibNull.
>
>We could link DxeSmmPerformanceLib to make DP command
>built from PerformancePkg and ShellPkg generic.
>
>Star Zeng (2):
>  PerformancePkg: Link DxeSmmPerformanceLib to make DP command
>generic
>  ShellPkg: Link DxeSmmPerformanceLib to make DP command generic
>
> PerformancePkg/PerformancePkg.dsc | 21 ++-------------------
> ShellPkg/ShellPkg.dsc             |  2 +-
> 2 files changed, 3 insertions(+), 20 deletions(-)
>
>--
>2.8.1.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP command generic

[Carsey, Jaben]

Agree with comments.  Great way to make build easier.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, February 28, 2017 11:57 PM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: RE: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP
> command generic
> Importance: High
> 
> It's great we finally have a platform independent PerformanceLib.
> Reviewed-by: Ruiyu Ni <Ruiyu.ni@intel.com>
> 
> Thanks/Ray
> 
> > -----Original Message-----
> > From: Zeng, Star
> > Sent: Wednesday, March 1, 2017 3:53 PM
> > To: edk2-devel@lists.01.org
> > Cc: Zeng, Star <star.zeng@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> > Carsey, Jaben <jaben.carsey@intel.com>; Gao, Liming
> > <liming.gao@intel.com>
> > Subject: [PATCH 2/2] ShellPkg: Link DxeSmmPerformanceLib to make DP
> > command generic
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=412
> >
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Star Zeng <star.zeng@intel.com>
> > ---
> >  ShellPkg/ShellPkg.dsc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index
> > a87428ad6f76..4126e846cf71 100644
> > --- a/ShellPkg/ShellPkg.dsc
> > +++ b/ShellPkg/ShellPkg.dsc
> > @@ -107,7 +107,7 @@ [Components]
> >
> >    ShellPkg/Library/UefiDpLib/UefiDpLib.inf {
> >      <LibraryClasses>
> > -
> >
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/BasePerformanc
> > eLibNull.inf
> > +
> > +
> >
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> > Perform
> > + anceLib.inf
> >        DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >    }
> >
> > --
> > 2.8.1.windows.1