From: Jordan Justen <jordan.l.justen@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib
Date: Tue, 14 Mar 2017 11:14:16 -0700 [thread overview]
Message-ID: <148951525611.24552.5051870457659495766@jljusten-skl> (raw)
In-Reply-To: <20170311062651.28351-1-lersek@redhat.com>
Series Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2017-03-10 22:26:39, Laszlo Ersek wrote:
> This is version 2 of the series posted at
> <https://lists.01.org/pipermail/edk2-devel/2017-February/007690.html>.
>
> Changes in this version:
> - pick up v1 R-b's from Jordan and Ard (patches 1-6)
> - rename QemuFwCfgS3TransferOwnership to
> QemuFwCfgS3CallWhenBootScriptReady [Jordan]
> - rename FW_CFG_BOOT_SCRIPT_APPEND_FUNCTION to
> FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION [Jordan]
> - rename "Append" to "Callback" and "mAppend" to "mCallback" [Laszlo]
> - rename QemuFwCfgS3WriteBytes, QemuFwCfgS3ReadBytes,
> QemuFwCfgS3SkipBytes, and QemuFwCfgS3CheckValue to
> QemuFwCfgS3ScriptWriteBytes, QemuFwCfgS3ScriptReadBytes,
> QemuFwCfgS3ScriptSkipBytes, and QemuFwCfgS3ScriptCheckValue,
> respectively [Jordan]
>
> Changes are noted per patch too.
>
> Rebuilt at every stage and retested (like in v1).
>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=394
> Repo: https://github.com/lersek/edk2.git
> Branch: fw_cfg_s3_v2
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
>
> Thanks
> Laszlo
>
> Laszlo Ersek (12):
> OvmfPkg: introduce QemuFwCfgS3Lib class
> OvmfPkg/QemuFwCfgS3Lib: add initial Base Null library instance
> OvmfPkg/QemuFwCfgS3Lib: add initial PEI and DXE fw_cfg library
> instances
> ArmVirtPkg: resolve QemuFwCfgS3Lib
> OvmfPkg: resolve QemuFwCfgS3Lib
> ArmVirtPkg, OvmfPkg: retire QemuFwCfgS3Enabled() from QemuFwCfgLib
> OvmfPkg/QemuFwCfgS3Lib: add boot script opcode generation APIs to
> libclass
> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for Base Null instance
> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for PEI fw_cfg instance
> OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for DXE fw_cfg instance
> OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib
> OvmfPkg/AcpiPlatformDxe: save fw_cfg boot script with QemuFwCfgS3Lib
>
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +
> ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 17 -
> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 2 +-
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +-
> OvmfPkg/AcpiPlatformDxe/BootScript.c | 262 ++-----
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 +
> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 +-
> OvmfPkg/Include/Library/QemuFwCfgLib.h | 14 -
> OvmfPkg/Include/Library/QemuFwCfgS3Lib.h | 361 +++++++++
> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 1 +
> OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 1 +
> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 +
> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 28 -
> OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf | 43 ++
> OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf | 46 ++
> OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf | 44 ++
> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c | 110 +++
> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c | 227 ++++++
> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c | 792 ++++++++++++++++++++
> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c | 86 +++
> OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c | 48 ++
> OvmfPkg/OvmfPkg.dec | 4 +
> OvmfPkg/OvmfPkgIa32.dsc | 3 +
> OvmfPkg/OvmfPkgIa32X64.dsc | 3 +
> OvmfPkg/OvmfPkgX64.dsc | 3 +
> OvmfPkg/PlatformPei/Platform.c | 1 +
> OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
> OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 224 ++----
> OvmfPkg/SmmControl2Dxe/SmiFeatures.h | 5 +-
> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 6 +-
> OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 1 +
> 33 files changed, 1924 insertions(+), 425 deletions(-)
> create mode 100644 OvmfPkg/Include/Library/QemuFwCfgS3Lib.h
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c
> create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c
>
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-03-14 18:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 6:26 [PATCH v2 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 01/12] OvmfPkg: introduce QemuFwCfgS3Lib class Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 02/12] OvmfPkg/QemuFwCfgS3Lib: add initial Base Null library instance Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 03/12] OvmfPkg/QemuFwCfgS3Lib: add initial PEI and DXE fw_cfg library instances Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 04/12] ArmVirtPkg: resolve QemuFwCfgS3Lib Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 05/12] OvmfPkg: " Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 06/12] ArmVirtPkg, OvmfPkg: retire QemuFwCfgS3Enabled() from QemuFwCfgLib Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 07/12] OvmfPkg/QemuFwCfgS3Lib: add boot script opcode generation APIs to libclass Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 08/12] OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for Base Null instance Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 09/12] OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for PEI fw_cfg instance Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 10/12] OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for DXE " Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 11/12] OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib Laszlo Ersek
2017-03-11 6:26 ` [PATCH v2 12/12] OvmfPkg/AcpiPlatformDxe: " Laszlo Ersek
2017-03-14 18:14 ` Jordan Justen [this message]
2017-03-14 20:56 ` [PATCH v2 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148951525611.24552.5051870457659495766@jljusten-skl \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox