From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 890B0803DD for ; Tue, 14 Mar 2017 11:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1489515257; x=1521051257; h=mime-version:content-transfer-encoding:to:message-id: from:in-reply-to:cc:references:subject:date; bh=R0oR1yAAoUgSD82sWtqQSu3hDezikFHY163Bi8eXkoM=; b=tOdMxLSs15EDFuMSMEudG+DLMXGgUzLeHcNqLYAvGQSIHPbnSPvmQZFd 0unARQYqB19079oo3GLQE/Idqa2PiA==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2017 11:14:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,165,1486454400"; d="scan'208";a="834588914" Received: from yjiang5-mobl.amr.corp.intel.com (HELO localhost) ([10.254.127.228]) by FMSMGA003.fm.intel.com with ESMTP; 14 Mar 2017 11:14:16 -0700 MIME-Version: 1.0 To: Laszlo Ersek , edk2-devel-01 Message-ID: <148951525611.24552.5051870457659495766@jljusten-skl> From: Jordan Justen In-Reply-To: <20170311062651.28351-1-lersek@redhat.com> Cc: Ard Biesheuvel References: <20170311062651.28351-1-lersek@redhat.com> User-Agent: alot/0.5.1 Date: Tue, 14 Mar 2017 11:14:16 -0700 Subject: Re: [PATCH v2 00/12] ArmVirtPkg, OvmfPkg: factor out QemuFwCfgS3Lib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 18:14:17 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Jordan Justen On 2017-03-10 22:26:39, Laszlo Ersek wrote: > This is version 2 of the series posted at > . > = > Changes in this version: > - pick up v1 R-b's from Jordan and Ard (patches 1-6) > - rename QemuFwCfgS3TransferOwnership to > QemuFwCfgS3CallWhenBootScriptReady [Jordan] > - rename FW_CFG_BOOT_SCRIPT_APPEND_FUNCTION to > FW_CFG_BOOT_SCRIPT_CALLBACK_FUNCTION [Jordan] > - rename "Append" to "Callback" and "mAppend" to "mCallback" [Laszlo] > - rename QemuFwCfgS3WriteBytes, QemuFwCfgS3ReadBytes, > QemuFwCfgS3SkipBytes, and QemuFwCfgS3CheckValue to > QemuFwCfgS3ScriptWriteBytes, QemuFwCfgS3ScriptReadBytes, > QemuFwCfgS3ScriptSkipBytes, and QemuFwCfgS3ScriptCheckValue, > respectively [Jordan] > = > Changes are noted per patch too. > = > Rebuilt at every stage and retested (like in v1). > = > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D394 > Repo: https://github.com/lersek/edk2.git > Branch: fw_cfg_s3_v2 > = > Cc: Ard Biesheuvel > Cc: Jordan Justen > = > Thanks > Laszlo > = > Laszlo Ersek (12): > OvmfPkg: introduce QemuFwCfgS3Lib class > OvmfPkg/QemuFwCfgS3Lib: add initial Base Null library instance > OvmfPkg/QemuFwCfgS3Lib: add initial PEI and DXE fw_cfg library > instances > ArmVirtPkg: resolve QemuFwCfgS3Lib > OvmfPkg: resolve QemuFwCfgS3Lib > ArmVirtPkg, OvmfPkg: retire QemuFwCfgS3Enabled() from QemuFwCfgLib > OvmfPkg/QemuFwCfgS3Lib: add boot script opcode generation APIs to > libclass > OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for Base Null instance > OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for PEI fw_cfg instance > OvmfPkg/QemuFwCfgS3Lib: implement opcode APIs for DXE fw_cfg instance > OvmfPkg/SmmControl2Dxe: save fw_cfg boot script with QemuFwCfgS3Lib > OvmfPkg/AcpiPlatformDxe: save fw_cfg boot script with QemuFwCfgS3Lib > = > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 17 - > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 2 = +- > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 = +- > OvmfPkg/AcpiPlatformDxe/BootScript.c | 262 = ++----- > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 8 + > OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 2 = +- > OvmfPkg/Include/Library/QemuFwCfgLib.h | 14 - > OvmfPkg/Include/Library/QemuFwCfgS3Lib.h | 361 = +++++++++ > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 1 + > OvmfPkg/Library/LockBoxLib/LockBoxDxeLib.inf | 1 + > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 + > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 28 - > OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf | 43 = ++ > OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf | 46 = ++ > OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf | 44 = ++ > OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c | 110 = +++ > OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c | 227 = ++++++ > OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c | 792 = ++++++++++++++++++++ > OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c | 86 = +++ > OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c | 48 = ++ > OvmfPkg/OvmfPkg.dec | 4 + > OvmfPkg/OvmfPkgIa32.dsc | 3 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 3 + > OvmfPkg/PlatformPei/Platform.c | 1 + > OvmfPkg/PlatformPei/PlatformPei.inf | 1 + > OvmfPkg/SmmControl2Dxe/SmiFeatures.c | 224 = ++---- > OvmfPkg/SmmControl2Dxe/SmiFeatures.h | 5 = +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.c | 6 = +- > OvmfPkg/SmmControl2Dxe/SmmControl2Dxe.inf | 1 + > 33 files changed, 1924 insertions(+), 425 deletions(-) > create mode 100644 OvmfPkg/Include/Library/QemuFwCfgS3Lib.h > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull= .inf > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg= .inf > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg= .inf > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3BasePei.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Dxe.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Pei.c > create mode 100644 OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3PeiDxe.c > = > -- = > 2.9.3 >=20